-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Update-rat is now consuming the new JRC API which provides information about RAT test being removed from the common list. Script feeds active attribute based on RAT database and writes date of removal of the test in the version attrbute. This is a slightly modified script created by Daniel Karlsson.
@kruzikh Could you put the |
@kruzikh Could you document the meaning of the Also: the jq expression is quite non-trivial. Is it an option to implement this functionality in Python if it needs to perform more complicated functionality? |
|
I would also like to see the order of the fields in the output made consistent with the current version, and also something added to the readme.md in the root of the repository to document the script (another PR is fine). Otherwise it's fine - it falls into the zone where shell scripts are effective; so IMO no need to rewrite it in a scripting language :) |
README added, script modified to hane order of elements as required.
If it ain't broke, don't fix it ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- decide on version - major (2.0.0), minor (1.4.0) or patch (1.3.1) - see https://semver.org/ for guidance if unsure
- CET -> CEST -> UTC?
As information about insertion/removal of the item into/from HSC common list is provided only to date (no time), the script was changed and version element is now filled only with the date (of last change in JRC database or removal from HSC list).
Update-rat is now consuming the new JRC API which provides information about RAT test being removed from the common list. Script feeds active attribute based on RAT database and writes date of removal of the test in the version attrbute. This is a slightly modified script created by Daniel Karlsson.