Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Spelling issue in test manufacturer 1343 #43

Closed
SMonday opened this issue Jan 12, 2022 · 5 comments · Fixed by #68
Closed

Spelling issue in test manufacturer 1343 #43

SMonday opened this issue Jan 12, 2022 · 5 comments · Fixed by #68
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@SMonday
Copy link

SMonday commented Jan 12, 2022

Manufacturer with ID 1343 has a typo:

Is: Zhezhiang Orient Gene Biotech Co., Ltd
Should be: Zhejiang Orient Gene Biotech Co.,Ltd.

See also https://covid-19-diagnostics.jrc.ec.europa.eu/devices/detail/1343

@SMonday SMonday changed the title Speeling issue in test manufacturer 1343 Spelling issue in test manufacturer 1343 Jan 12, 2022
@skounis
Copy link
Contributor

skounis commented Jan 14, 2022

This refers to

However, the RATs are not maintained in this repository anymore. The Gateway is pulling them directly from the database of JRC.

To avoid any confusion I would suggest taking the test-manf.json file completely out.

@ryanbnl @dslmeinte ?

@skounis skounis self-assigned this Jan 14, 2022
@dslmeinte
Copy link
Contributor

@skounis Agreed, but we should also provide clear instructions on how, and preferably a script to obtain the test-manf.json from the Gateway.

@ryanbnl ryanbnl added the enhancement New feature or request label May 24, 2022
@ryanbnl ryanbnl added this to the 2022-06-10 milestone Jun 8, 2022
@ryanbnl
Copy link
Contributor

ryanbnl commented Jun 8, 2022

Add to the agenda for Friday. The options are:

  • Leave as-is.
  • Rename test-manf-snapshot-yyyy-dd-mm.json so it's clear that this file is a snapshot!
  • Remove completely.
  • Remove but provide an example containing a small number of fictional examples, using a different but similar file name to avoid confusion.
  • Use github actions to automatically update the file daily.

@dslmeinte
Copy link
Contributor

I vote for option #4: replace test-manf.json with an example file with a different name.

@skounis skounis removed their assignment Feb 6, 2023
@ryanbnl ryanbnl self-assigned this Feb 16, 2023
@ryanbnl ryanbnl linked a pull request Feb 17, 2023 that will close this issue
@ryanbnl
Copy link
Contributor

ryanbnl commented Feb 24, 2023

Resolved

@ryanbnl ryanbnl closed this as completed Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants