Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NewRESTAddress use http as default scheme #991

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

judehung
Copy link
Member

@judehung judehung commented Mar 10, 2025

fixes #990

The PR #986 set the scheme configurable in NewRESTAddress, but didn't consider a default value when scheme is empty string.

This commit will set http as the default value when scheme is an empty string.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

fixes edgexfoundry#990

The PR edgexfoundry#986 set the scheme
configurable in NewRESTAddress, but didn't consider a default value when
scheme is empty string.

This commit will set http as the default value when scheme is an empty string.

Signed-off-by: Jude Hung <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.93%. Comparing base (b20d5f4) to head (f54e88f).

Files with missing lines Patch % Lines
dtos/address.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
- Coverage   42.95%   42.93%   -0.02%     
==========================================
  Files         119      119              
  Lines        7206     7208       +2     
==========================================
  Hits         3095     3095              
- Misses       3768     3770       +2     
  Partials      343      343              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@judehung judehung marked this pull request as ready for review March 10, 2025 02:22
@judehung judehung requested a review from cloudxxx8 March 10, 2025 02:22
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit de36d96 into edgexfoundry:main Mar 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications NewRESTAddress function should set http as the default value for backward compatibility
3 participants