feat: Add HTTPS support to REST #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudxxx8
requested changes
Mar 4, 2025
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 42.95% 42.95% -0.01%
==========================================
Files 119 119
Lines 7205 7206 +1
==========================================
Hits 3095 3095
- Misses 3767 3768 +1
Partials 343 343 ☔ View full report in Codecov by Sentry. |
cloudxxx8
requested changes
Mar 4, 2025
Signed-off-by: Yangsta911 <[email protected]>
Signed-off-by: Yangsta911 <[email protected]>
judehung
added a commit
to judehung/go-mod-core-contracts
that referenced
this pull request
Mar 10, 2025
The PR edgexfoundry#986 set the scheme configurable in NewRESTAddress, but didn't consider a default value when scheme is empty string. This commit will set http as the default value when scheme is an empty string. Signed-off-by: Jude Hung <[email protected]>
judehung
added a commit
to judehung/go-mod-core-contracts
that referenced
this pull request
Mar 10, 2025
fixes edgexfoundry#990 The PR edgexfoundry#986 set the scheme configurable in NewRESTAddress, but didn't consider a default value when scheme is empty string. This commit will set http as the default value when scheme is an empty string. Signed-off-by: Jude Hung <[email protected]>
5 tasks
judehung
added a commit
to judehung/go-mod-core-contracts
that referenced
this pull request
Mar 10, 2025
fixes edgexfoundry#990 The PR edgexfoundry#986 set the scheme configurable in NewRESTAddress, but didn't consider a default value when scheme is empty string. This commit will set http as the default value when scheme is an empty string. Signed-off-by: Jude Hung <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add HTTPS support to REST
Closes edgexfoundry/edgex-go#5099
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)