Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add injectEdgeXAuth boolean attribute to RESTAddress types #880

Merged

Conversation

jrtitus
Copy link
Contributor

@jrtitus jrtitus commented Feb 23, 2024

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Requires update of edgex-go support notifications. See edgexfoundry/edgex-go#4747 (comment)

New Dependency Instructions (If applicable)

N/A

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 61.08%. Comparing base (a40ef71) to head (66ec24c).

Files Patch % Lines
dtos/address.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   61.12%   61.08%   -0.04%     
==========================================
  Files          85       85              
  Lines        3534     3536       +2     
==========================================
  Hits         2160     2160              
- Misses       1165     1167       +2     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it's a feature enhancement, please modify your commit prefix to feat:
this will impact the future release notes generation

@jrtitus jrtitus force-pushed the feat/authenticated-notifications branch from cf9fc9b to 66ec24c Compare February 23, 2024 17:31
@jrtitus jrtitus changed the title refactor: add injectEdgeXAuth boolean attribute to RESTAddress types feat: add injectEdgeXAuth boolean attribute to RESTAddress types Feb 24, 2024
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 1f276e7 into edgexfoundry:main Feb 27, 2024
3 checks passed
@jrtitus jrtitus deleted the feat/authenticated-notifications branch February 28, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants