-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow sending notifications to authenticated EdgeX endpoints #4763
feat: allow sending notifications to authenticated EdgeX endpoints #4763
Conversation
Signed-off-by: Jeff Titus <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4763 +/- ##
=======================================
Coverage 41.55% 41.55%
=======================================
Files 105 105
Lines 9834 9834
=======================================
Hits 4087 4087
Misses 5395 5395
Partials 352 352 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jeff Titus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… v3.2.0-dev.9 Signed-off-by: Jeff Titus <[email protected]>
Signed-off-by: Jeff Titus <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #4747
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
See #4747 (comment)
New Dependency Instructions (If applicable)
In draft state due to dependency on change ingo-mod-core-contracts