Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add core-data postgres reading db client methods #4862

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Aug 14, 2024

Relates to #4847. Add core-data reading related db client methods for postgres client.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Relates to edgexfoundry#4847. Add core-data reading related db client methods for postgres client.

Signed-off-by: Lindsey Cheng <[email protected]>
Add a new Reading model for postgres for insert/query reading usage.

Signed-off-by: Lindsey Cheng <[email protected]>
Remove unused sql util function to fix linter check.

Signed-off-by: Lindsey Cheng <[email protected]>
@lindseysimple
Copy link
Contributor Author

@cloudxxx8 PR's ready for review, thanks.

Use type switch to convert the reading interface type to reading structs.

Signed-off-by: Lindsey Cheng <[email protected]>
Copy link

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 9ed7212 into edgexfoundry:main Aug 16, 2024
6 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-4847-2 branch August 16, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants