Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Core Data to support PostgreSQL as persistence layer #4847

Closed
lindseysimple opened this issue Aug 2, 2024 · 0 comments · Fixed by #4870
Closed

Enhance Core Data to support PostgreSQL as persistence layer #4847

lindseysimple opened this issue Aug 2, 2024 · 0 comments · Fixed by #4870
Assignees
Labels
enhancement New feature or request

Comments

@lindseysimple
Copy link
Contributor

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for EdgeX Core Data Service.

Description [REQUIRED]

As PostgresSQL will become an available database type option in addition to RedisDB, enhance the Postgres DB Client to support Core Data related methods.

Describe the solution you'd like

New Postgres database schemas and tables will be needed for Core Data service in order to support using Postgres as the available database type in Core Data, and the related DB methods implementation as well.

@lindseysimple lindseysimple added the enhancement New feature or request label Aug 2, 2024
@lindseysimple lindseysimple self-assigned this Aug 2, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Aug 2, 2024
@lindseysimple lindseysimple moved this from New Issues to In Progress in Technical WG Aug 2, 2024
@cloudxxx8 cloudxxx8 changed the title Enhance Core Data to support PostgresSQL as persistence layer Enhance Core Data to support PostgreSQL as persistence layer Aug 6, 2024
lindseysimple added a commit to lindseysimple/edgex-go that referenced this issue Aug 7, 2024
Relates to edgexfoundry#4847. Add core-data event related db methods for postgres db client.

Signed-off-by: Lindsey Cheng <[email protected]>
cloudxxx8 pushed a commit that referenced this issue Aug 12, 2024
* feat: Add core-data event related db methods for postgres

Relates to #4847. Add core-data event related db methods for postgres db client.

Signed-off-by: Lindsey Cheng <[email protected]>

* fix: Define json query string as query argument

Define json query string as query argument instead of in sql statement.

Signed-off-by: Lindsey Cheng <[email protected]>

* fix: Update core-data event table design

Update event design based on the event struct fields to have multi columns.

Signed-off-by: Lindsey Cheng <[email protected]>

---------

Signed-off-by: Lindsey Cheng <[email protected]>
lindseysimple added a commit to lindseysimple/edgex-go that referenced this issue Aug 14, 2024
Relates to edgexfoundry#4847. Add core-data reading related db client methods for postgres client.

Signed-off-by: Lindsey Cheng <[email protected]>
cloudxxx8 pushed a commit that referenced this issue Aug 16, 2024
* feat: Add core-data postgres reading db client methods

Relates to #4847. Add core-data reading related db client methods for postgres client.

Signed-off-by: Lindsey Cheng <[email protected]>

* fix: Add a new Reading model for postgres

Add a new Reading model for postgres for insert/query reading usage.

Signed-off-by: Lindsey Cheng <[email protected]>

* fix: Remove unused sql util function

Remove unused sql util function to fix linter check.

Signed-off-by: Lindsey Cheng <[email protected]>

* fix: Use type switch to get the reading type for inserting reading

Use type switch to convert the reading interface type to reading structs.

Signed-off-by: Lindsey Cheng <[email protected]>

---------

Signed-off-by: Lindsey Cheng <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Odessa Done in Technical WG Aug 21, 2024
lindseysimple added a commit to lindseysimple/edgex-go that referenced this issue Aug 23, 2024
Relates to edgexfoundry#4847. Add more db config in service private config in order to use env variable overwrite to support Postgres in some services.

Signed-off-by: Lindsey Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Odessa Done
Development

Successfully merging a pull request may close this issue.

1 participant