refactor: Rework for refactoring go-mod-secrets #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
requested changes
Feb 19, 2021
lenny-goodell
force-pushed
the
refactored-secrets
branch
2 times, most recently
from
ba9a289 to
a1bc207
Compare
bnevis-i
reviewed
Feb 19, 2021
bnevis-i
reviewed
Feb 19, 2021
bnevis-i
reviewed
Feb 19, 2021
bnevis-i
reviewed
Feb 19, 2021
bnevis-i
previously approved these changes
Feb 19, 2021
jim-wang-intel
requested changes
Feb 19, 2021
lenny-goodell
force-pushed
the
refactored-secrets
branch
from
f6d9013 to
75abd5e
Compare
lenny-goodell
force-pushed
the
refactored-secrets
branch
from
f81bd2e to
bd7f0cb
Compare
added 5 commits
February 19, 2021 16:41
Moved SecretStoreClient to go-mod-secrets Cleaned up configuation to be more consistant across services closes edgexfoundry#3180 Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
refactored-secrets
branch
from
bd7f0cb to
c2fb34d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
SecretStoreClinet in this repo, not in go-mod-secrets.
Inconsistant configuration for SecretStore
Issue Number: #3180
What is the new behavior?
Moved SecretStoreClient to go-mod-secrets
Cleaned up configuration to be more consistent across services
SecrectService confg names chnaged to SecretStore for Proxy Setup and SecretStore Setup
Added
Type = 'vault'to all[SecretStore]configurationsDependent on these PRs:
edgexfoundry/go-mod-secrets#91
edgexfoundry/go-mod-bootstrap#171
Does this PR introduce a breaking change?
BREAKING CHANGE:
All existing SecretStore configuration must add Type = 'vault'
SecrectService confg names chnaged to SecretStore for Proxy Setup and SecretStore Setup
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information