refactor: More rework and TODO for PR comments

Signed-off-by: lenny <[email protected]>

Author: lenny

internal/security/fileprovider/init.go

@@ -82,6 +82,7 @@ func (b *Bootstrap) BootstrapHandler(_ context.Context, _ *sync.WaitGroup, _ sta
 	if err != nil {
 		lc.Errorf("error occurred creating SecretStoreClient: %s", err.Error())
 		b.exitCode = 1
+		return false
 	}
 
 	fileProvider := NewTokenProvider(lc, fileOpener, tokenProvider, client)

internal/security/secretstore/init.go

@@ -143,6 +143,8 @@ func (b *Bootstrap) BootstrapHandler(ctx context.Context, _ *sync.WaitGroup, _ s
 				initResponse, err = client.Init(secretStoreConfig.VaultSecretThreshold, secretStoreConfig.VaultSecretShares)
 				if err != nil {
 					lc.Errorf("Unable to Initialize Vault: %s. Will try again...", err.Error())
+					// TODO: This function should be refactored to resolve logic issue where we are returning
+					//       success=true when there was an error. Function be extracted out so it is no longer in-line.
 					return true
 				}