Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed remote/file logging feature #696

Merged
merged 2 commits into from
Dec 28, 2020
Merged

feat: Removed remote/file logging feature #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc1ee3
feat: Removed remote logging feature
Dec 16, 2020
c3fceda
Merge branch 'master' into remove-remote-logger
lenny-goodell Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions example/cmd/device-simple/res/configuration.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ Type = 'consul'
Host = 'localhost'
Port = 48081

[Clients.Logging]
Protocol = 'http'
Host = 'localhost'
Port = 48061

[Device]
DataTransform = true
InitCmd = ''
Expand All @@ -49,11 +44,6 @@ Type = 'consul'
Enabled = false
Interval = '30s'

# Remote and file logging disabled so only stdout logging is used
[Logging]
EnableRemote = false
File = ''

# Pre-define Devices
[[DeviceList]]
Name = 'Simple-Device01'
Expand Down
3 changes: 0 additions & 3 deletions internal/common/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ type ConfigurationStruct struct {
Writable WritableInfo
// Clients is a map of services used by a DS.
Clients map[string]bootstrapConfig.ClientInfo
// Logging contains logging-specific configuration settings.
Logging bootstrapConfig.LoggingInfo
// Registry contains registry-specific settings.
Registry bootstrapConfig.RegistryInfo
// Service contains DeviceService-specific settings.
Expand Down Expand Up @@ -69,7 +67,6 @@ func (c *ConfigurationStruct) GetBootstrap() bootstrapConfig.BootstrapConfigurat
Clients: c.Clients,
Service: c.Service.GetBootstrapServiceInfo(),
Registry: c.Registry,
Logging: c.Logging,
}
}

Expand Down
9 changes: 0 additions & 9 deletions openapi/v1/device-sdk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,12 +529,6 @@ components:
Port: 48080
Protocol: http
Timeout: 50000
Logging:
Name: edgex-support-logging
Host: localhost
Port: 48061
Protocol: http
Timeout: 0
Metadata:
Name: edgex-core-metadata
Host: localhost
Expand All @@ -550,9 +544,6 @@ components:
RemoveCmd: ''
RemoveCmdArgs: ''
ProfilesDir: ./res/example
Logging:
EnableRemote: false
File: ./device-mqtt.log
Watchers: null
DeviceList:
- Name: MQ_DEVICE
Expand Down