Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed remote/file logging feature #696

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Dec 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/master/.github/CONTRIBUTING.md

What is the current behavior?

Remote/file logging feature still available

Issue Number: #544

What is the new behavior?

Remote/file logging feature has been removed

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Other information

@lenny-goodell lenny-goodell changed the title feat: Removed remote logging feature feat: Removed remote/file logging feature Dec 16, 2020
@lenny-goodell lenny-goodell linked an issue Dec 16, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #696 (1cc1ee3) into master (4525aed) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   45.89%   45.91%   +0.01%     
==========================================
  Files          31       31              
  Lines        3085     3084       -1     
==========================================
  Hits         1416     1416              
+ Misses       1556     1555       -1     
  Partials      113      113              
Impacted Files Coverage Δ
internal/common/config.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4525aed...1cc1ee3. Read the comment docs.

@cloudxxx8 cloudxxx8 added the hold Intended for PRs we want to flag for ongoing review label Dec 18, 2020
@cloudxxx8
Copy link
Member

hold for the SDK dot release

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 42e5a1e into edgexfoundry:master Dec 28, 2020
@lenny-goodell lenny-goodell deleted the remove-remote-logger branch December 28, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Intended for PRs we want to flag for ongoing review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Logging Service (Device SDK Go code clean up)
3 participants