-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LS not working for Java Maven #16051
Comments
@tsmaeder FYI |
Additional logs: theia-ide logs
vscode logs
browser logs
|
Maven support is not used with this example: since the example contains both gradle and maven config files, jdt.ls imports it as a gradle project. |
Actually, gradle support seems to be broken: creating a gradle workspace shows the same problem. |
@tsmaeder should we put a blocker here? or is it a project-specific issue |
I have no idea and all the folks that were on PTO yesterday. |
Turns out this is a VSCode-Java problem: if I clean all the VS Code and gradle related files from my local machine (~/.gradle, ~/AppData/Roaming/Code, etc.) I can reproduce this with VS Code. |
...is pretty self explanatory. Looks like your project's gradle wrapper points to a snapshot build of gradle that no longer exists. Building it would fail even on CLI. Try updating gradle/wrapper/gradle-wrapper.properties to a stable version. See https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper |
There is no gradle wrapper related stuff in that project. Still trying to find out why gradle tooling wants to download that snapshot |
setting blocker as it blocks all happy paths on all PRs |
I'm wondering how are we going to release 7.9.0 with this issue? this also looks like a blocker for Hosted Che update |
@tsmaeder Could you try https://github.com/snjeza/vscode-test/raw/master/java-0.57.0.vsix ? |
@snjeza not today. |
Also, this is not a blocker for CRW 2.1 using Che 7.9, as they have their own plugin registry. |
@tsmaeder who will look in your team then ? AFAIK you're also on PTO tomorrow/friday |
I confirmed the issue with vscode-java 0.56.0 and checked it's fixed in 0.57.0. Once we release it, how fast can you pick it up? |
as an alternative, you can add the gradle wrapper, pointing to a stable gradle version, in the example repo |
Here's the deal: VS Code Java is going to release a fixed version today. We'll be able to update to that version. |
PR is here eclipse-che/che-plugin-registry#387 |
PR merged. |
Followup PR for quarkus jdk 8 also merged: eclipse-che/che-plugin-registry#388 Next up, I'll delete the existing plugin registry 7.9.0 release and redo it: ... https://github.com/eclipse/che-plugin-registry/commits/7.9.0 fixed
|
Note to future hackers... the make-release.sh script does NOT work for doing re-releases. It crapped the bed and ended up pushing master branch to release branch instead. Since re-releases SHOULD be rare, I'm not going to implement the above re-release flow just yet. |
@tsmaeder, @svor: an issue is still actual
|
another PR fix: eclipse-che/che-plugin-registry#390 (merged) Will respin 7.9.0 plugin reg again now. |
https://ci.centos.org/job/devtools-che-plugin-registry-release/27/ spinning to rebuild after above PR merged. |
Java Maven devfie tests have been fixed: https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/basic-MultiUser-Che-check-e2e-tests-against-k8s/972/console |
followup work to ensure we don't have incorrect |
Describe the bug
The LS is not working for a Java Maven workspace. It seems like LS is initialized but then it does not work: error highlighting, suggestions neither the
ctrl + left click
to open class in new tab.Che version
Steps to reproduce
HelloWorld.java
in console-java-simple/src/main/java/org/eclipse/che/examplesCtrl + left click
(none of them should work)[1]

Expected behavior
The LS should be correctly initialized or some error should be shown for a user.
Runtime
kubectl version
)oc version
)oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0
features: Basic-Auth GSSAPI Kerberos SPNEGO
Server https://api.ocp42.codereadyqe.com:6443
kubernetes v1.14.6+8bbaf43
minikube version
andkubectl version
)minishift version
andoc version
)docker version
andkubectl version
)Screenshots
Installation method
chectl server:start -a operator -p openshift -b crw.codeready.com -n katka
Environment
The text was updated successfully, but these errors were encountered: