Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin registry] invalid name field not caught by validation checkers when name is valid (but for a different plugin) #16107

Closed
1 of 23 tasks
nickboldt opened this issue Feb 21, 2020 · 3 comments
Assignees
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@nickboldt
Copy link
Contributor

Describe the bug

The problem is that name:java IS valid but for a different plugin; should have been name:java8 and name:java11 ... and no check caught that afaict. or at least nothing in GH complained about the PR that introduced the 0.57.0 versions of java8 and java11 plugins

So, we need to check that the PATH defined by the meta.yaml is the same as the PATH to the meta.yaml file.

Or better yet, ignore what's in the meta.yaml file, and regenerate the name: field when you're creating latest and doing other manipulations.

Che version

  • latest 7.9.0 / 7.10.0
  • nightly
  • other: please specify

Steps to reproduce

Expected behavior

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@nickboldt
Copy link
Contributor Author

Slip to next milestone

@amisevsk
Copy link
Contributor

@nickboldt This issue was actually due to an error in how the CI build was set up (failed checks weren't failing the build).

The reported problem is correctly caught by the check_plugins_location.sh script:

!!! Location mismatch in plugin 'redhat/java/0.57.0':
!!!   Expected location: './v3/plugins/redhat/java/0.57.0/meta.yaml'
!!!   Actual location: './v3/plugins/redhat/java11/0.57.0/meta.yaml' 

@amisevsk
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants