-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force Maven Devfiles to use Maven #16066
Comments
IMHO issue is that both maven and gradle examples are using the same github project. To me it's strange to turn false something while for a maven example I don't expect to see any gradle stuff in the project tree. |
@benoitf there is a separate issue for "use maven project for maven devfile". But it would still make sense to force use of maven with a maven stack. |
@tsmaeder yes makes sense on general purpose but the description of the issue is specifically about the example used in maven stack and then for the specific maven example it should not include any gradle file. |
If we have a project that has both maven and gradle configs (which is quite common), jdt.ls will pick gradle. This might not be the right thing to do. If we have a stack that is made for maven, we should always force usage of maven in the tooling (because that's what will be used in the dev container). |
@tsmaeder ok so your proposal is to update the java-maven devfile in the registry to include the jdt ls option |
Well, for small values of "fix". Since gradle support is totally broken for new workspaces right now. We'll get a new release of VS Code Java later today where the issue is fixed and should update to that. |
@tsmaeder yes but the original issue is about using maven not gradle. And the difference is important since it's part of the happy path test that's used in all our PR checks. |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Right now, our Maven devfile uses an example that also has a build.gradle. This will, in fact not be imported as a Maven project in jdt.ls, but as a Gradle project (Gradle has precedence).
There is preference in VS Code Java (something like "gradle.importer.enabled") that we can turn to false in the devfile in order to force use of Maven.
The text was updated successfully, but these errors were encountered: