Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create L3 Client APIs for uSubscription Service #148

Closed
stevenhartley opened this issue Jul 11, 2024 · 1 comment
Closed

Create L3 Client APIs for uSubscription Service #148

stevenhartley opened this issue Jul 11, 2024 · 1 comment
Assignees
@stevenhartley
Labels
enhancement New feature or request

Comments

@stevenhartley
Copy link

stevenhartley commented Jul 11, 2024 •
edited
Loading

the InMemorySubscriber was trying to implement the L2 API to start/stop receiving published events as well as the uSubscription business logic to talk uSubscription service and setup notifications. The following PR will be used to cleanup Subscriber API to focus only on L2 while moving all the uSubscription business logic into a new module dedicated for client-side L3 APIs for uSubscription service
@stevenhartley stevenhartley self-assigned this Jul 11, 2024
@stevenhartley stevenhartley added the enhancement New feature or request label Jul 12, 2024
@stevenhartley stevenhartley changed the title Add the remainder of USubscription APIs to Subscriber and Publisher APIs Add the remainder of USubscription APIs to the Publisher Interface and implementation Jul 15, 2024
@stevenhartley stevenhartley changed the title Add the remainder of USubscription APIs to the Publisher Interface and implementation Create L3 Client APIs for uSubscription Service Jul 15, 2024
stevenhartley pushed a commit that referenced this issue Jul 16, 2024
Move InMemorySubscriber from L2 communication module to L3 client mod…
61844e0 
…ule.

The InMemorySubscriber actually was implementing the client-side of the uSubscription flow by talking to usubscription service, registering a listener (to receive published messages), and setting up a notifier to receive subscription changes. The only L2 item for pub/sub (subscriber) flow was to register a listener with the transport so there is no need to add a wrapper to do that.
This change then also implements all the other remaining usubscription client side APIs for developers to use and removes the L2 Subscriber to avoid confusion with this InMemoryUSubscriptionClient implementation. The uProtocol client-side implementations will now reside in the client folder of up-java (ex. uDiscovery & uTwin).

#148
This was referenced Jul 16, 2024
Merged
Closed
@stevenhartley
Copy link
Author

merged by #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenhartley stevenhartley

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevenhartley