Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InMemorySubscriber should specify what version of the subscription protobuf it is working with #155

Closed
tamarafischer opened this issue Jul 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@tamarafischer
Copy link
Contributor

Currently we have version 2 and version 3 of the subscription protobuf.
version 2 is the one actually used, as of typing this issue. I am not sure who is using version 3.

InMemorySubscriber should specify the version or maybe have 2 versions of Subscriber, otherwise we might have problems understanding the payload.

@stevenhartley
Copy link

InMemorySubscriber is based off UTransport that is based off UMessages that are a part of 1.6.0 of uProtocol that will only be using in deployments that have v3 or later of uSubscription as v2 is not using Eclipse-uProtocol but the older closed source version of uProtocol.
That being said, we do need to consider supporting updated versions of the proto in the future (when we go from v3 to v4 whenever that might happen).

@stevenhartley stevenhartley added the enhancement New feature or request label Jul 15, 2024
@stevenhartley
Copy link

This is addressed by #148 and the PR #158 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants