Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch errors when linked tm is unavailable #928

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix: catch errors when linked tm is unavailable #928

merged 2 commits into from
Feb 16, 2023

Conversation

fatadel
Copy link
Contributor

@fatadel fatadel commented Feb 16, 2023

No description provided.

@fatadel fatadel force-pushed the catch-bad-http-code branch from f82ba45 to aae0c67 Compare February 16, 2023 15:15
relu91
relu91 requested changes Feb 16, 2023
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include the failed URL in the error? might be useful to understands which link in broken, when you compose multiple TMs

@fatadel
embed uri when failing
79055e8 
Signed-off-by: fatadel <[email protected]>
@fatadel
Copy link
Contributor Author

fatadel commented Feb 16, 2023

Can you include the failed URL in the error? might be useful to understands which link in broken, when you compose multiple TMs

Done ✅

@fatadel fatadel requested a review from relu91 February 16, 2023 16:27
@danielpeintner
Copy link
Member

Note: I am not sure why the CI runs take that long...

@relu91 relu91 merged commit c59ea4b into eclipse-thingweb:master Feb 16, 2023
@fatadel fatadel deleted the catch-bad-http-code branch February 16, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@danielpeintner danielpeintner danielpeintner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatadel @danielpeintner @relu91