fix: catch errors when linked tm is unavailable

Signed-off-by: fatadel <[email protected]>
eclipse-thingweb · Feb 16, 2023 · aae0c67 · aae0c67
1 parent 9d9fdf6
commit aae0c67
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 0 deletions.
diff --git a/packages/td-tools/src/thing-model-helpers.ts b/packages/td-tools/src/thing-model-helpers.ts
@@ -241,6 +241,10 @@ export class ThingModelHelpers {
             case "http": {
                 return new Promise((resolve, reject) => {
                     http.get(uri, (res) => {
+                        if (!res.statusCode || res.statusCode !== 200) {
+                            reject(new Error(`http status code not 200 but ${res.statusCode}`));
+                        }
+
                         res.setEncoding("utf8");
                         let rawData = "";
                         res.on("data", (chunk) => {
@@ -264,6 +268,10 @@ export class ThingModelHelpers {
                 return new Promise((resolve, reject) => {
                     https
                         .get(uri, (res) => {
+                            if (!res.statusCode || res.statusCode !== 200) {
+                                reject(new Error(`https status code not 200 but ${res.statusCode}`));
+                            }
+
                             res.setEncoding("utf8");
                             let rawData = "";
                             res.on("data", (chunk) => {

diff --git a/packages/td-tools/test/ThingModelHelperTest.ts b/packages/td-tools/test/ThingModelHelperTest.ts
@@ -446,4 +446,48 @@ class ThingModelHelperTest {
         expect(validated.valid).to.be.false;
         expect(validated.errors).to.be.equal(`Missing required fields in map for model ${thing.title}`);
     }
+
+    @test async "should fail on unavailable linked ThingModel - http"() {
+        const thing = {
+            "@context": ["https://www.w3.org/2022/wot/td/v1.1"],
+            "@type": "tm:ThingModel",
+            title: "Dimmable Colored Lamp",
+            version: {
+                model: "1.0.0",
+            },
+            links: [
+                {
+                    rel: "tm:extends",
+                    href: "http://example.com/models/colored-lamp-1.0.0.tm.jsonld",
+                    type: "application/tm+json",
+                },
+            ],
+        } as unknown as ThingModel;
+
+        expect(this.thingModelHelpers.getPartialTDs(thing)).to.be.rejectedWith(
+            new Error("http status code not 200 but 404")
+        );
+    }
+
+    @test async "should fail on unavailable linked ThingModel - https"() {
+        const thing = {
+            "@context": ["https://www.w3.org/2022/wot/td/v1.1"],
+            "@type": "tm:ThingModel",
+            title: "Dimmable Colored Lamp",
+            version: {
+                model: "1.0.0",
+            },
+            links: [
+                {
+                    rel: "tm:extends",
+                    href: "https://example.com/models/colored-lamp-1.0.0.tm.jsonld",
+                    type: "application/tm+json",
+                },
+            ],
+        } as unknown as ThingModel;
+
+        expect(this.thingModelHelpers.getPartialTDs(thing)).to.be.rejectedWith(
+            new Error("https status code not 200 but 404")
+        );
+    }
 }