Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(binding-mqtt): remove unused debug import #1205

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore(binding-mqtt): remove unused debug import #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/binding-mqtt/src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { createLoggers } from "@node-wot/core";
import { MqttQoS } from "./mqtt";
import { IClientPublishOptions } from "mqtt";

const { debug, warn } = createLoggers("binding-mqtt", "mqtt-util");
const { warn } = createLoggers("binding-mqtt", "mqtt-util");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh interesting. I would have said that the code checks we have in place mention unused imports...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning popped up in other PRs as an additional warning not related to code being changed, which is how I noticed it – but yeah, strange that it slipped through 🤔


export function mapQoS(qos: MqttQoS | undefined): Required<IClientPublishOptions>["qos"] {
switch (qos) {
Expand Down
Loading