chore(binding-mqtt): remove unused debug import #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 77.44% 77.44%
=======================================
Files 82 82
Lines 17241 17241
Branches 1737 1737
=======================================
Hits 13352 13352
Misses 3854 3854
Partials 35 35 ☔ View full report in Codecov by Sentry. |
| @@ -16,7 +16,7 @@ import { createLoggers } from "@node-wot/core"; | |||
| import { MqttQoS } from "./mqtt"; | |||
| import { IClientPublishOptions } from "mqtt"; | |||
|
|
|||
| const { debug, warn } = createLoggers("binding-mqtt", "mqtt-util"); | |||
| const { warn } = createLoggers("binding-mqtt", "mqtt-util"); | |||
There was a problem hiding this comment.
Mhh interesting. I would have said that the code checks we have in place mention unused imports...
There was a problem hiding this comment.
The warning popped up in other PRs as an additional warning not related to code being changed, which is how I noticed it – but yeah, strange that it slipped through 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extremely trivial PR that gets rid of the single warning eslint is currently reporting on the
masterbranch.Since the change is so simple, I will merge it right away.