Workspace: add url encoding #9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Aug 5, 2021
There was a problem hiding this comment.
I noticed some unexpected behavior on browser reload:
- Open a workspace with
%20in its directory name - Observe that the fragment in the url does not contain the escaped sequence for
%20but instead a space character. - Reloading the browser window closes the workspace. (No workspace is selected upon reload)
Thank you @msujew , I'll take a look at that |
OmarSdt-EC
force-pushed
the
os/fix-encodeWorkspace
branch
3 times, most recently
from
dc323cd to
d718690
Compare
OmarSdt-EC
changed the title
msujew
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed by this change nicely. I tested this on both browser and Electron targets (Windows):
- Opening a directory with
%20in its name works correctly ✔️ - The encoded URL appears in the browser bar ✔️
- Reloading the application correctly brings one back to the previously opened project ✔️
OmarSdt-EC
force-pushed
the
os/fix-encodeWorkspace
branch
2 times, most recently
from
b0f0896 to
eed2909
Compare
The commit introduces the use of `encoding` when we are loading/reloading a workspace URL. Previously, the application would fail to open a workspace URL with reserved characters such as `%`.
OmarSdt-EC
force-pushed
the
os/fix-encodeWorkspace
branch
from
eed2909 to
6468e6b
Compare
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
The commit introduces the use of `encoding` when we are loading/reloading a workspace URL. Previously, the application would fail to open a workspace URL with reserved characters such as `%`.
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
The commit introduces the use of `encoding` when we are loading/reloading a workspace URL. Previously, the application would fail to open a workspace URL with reserved characters such as `%`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds the encoding of URIs. After this update, we can now
open workspaces with reserved symbols like '%' in their name.
What it does
FIxes #8909
The commit introduces the use of
encodingwhen we are loading/reloading a workspace URL.Previously, the application would fail to open a workspace URL with reserved characters such as
%.How to test
Review checklist
Reminder for reviewers