workspace: add url encoding

The commit introduces the use of `encoding` when we are loading/reloading a workspace URL.
Previously, the application would fail to open a workspace URL with reserved characters such as `%`.

packages/core/src/electron-main/electron-main-application.ts

@@ -277,7 +277,7 @@ export class ElectronMainApplication {
     protected async openWindowWithWorkspace(workspacePath: string): Promise<BrowserWindow> {
         const options = await this.getLastWindowOptions();
         const [uri, electronWindow] = await Promise.all([this.createWindowUri(), this.createWindow(options)]);
-        electronWindow.loadURL(uri.withFragment(workspacePath).toString(true));
+        electronWindow.loadURL(uri.withFragment(encodeURI(workspacePath)).toString(true));
         return electronWindow;
     }
 

packages/workspace/src/browser/workspace-service.ts

@@ -161,6 +161,7 @@ export class WorkspaceService implements FrontendApplicationContribution {
      * Set the URL fragment to the given workspace path.
      */
     protected setURLFragment(workspacePath: string): void {
+        workspacePath = encodeURI(workspacePath);
         window.location.hash = workspacePath;
     }
 
@@ -500,13 +501,12 @@ export class WorkspaceService implements FrontendApplicationContribution {
         } else {
             this.setURLFragment('');
         }
-
         window.location.reload(true);
     }
 
     protected openNewWindow(workspacePath: string): void {
         const url = new URL(window.location.href);
-        url.hash = workspacePath;
+        url.hash = encodeURI(workspacePath);
         this.windowService.openNewWindow(url.toString());
     }