Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk-edit: fix spelling mistake in border value #9100

Merged

Conversation

zhaomenghuan
Copy link
Contributor

@zhaomenghuan zhaomenghuan commented Feb 21, 2021

What it does

Fixes: #9216
Fixed bulk-edit extension's spelling mistake in border value

How to test

Spelling mistake changes only

Review checklist

Reminder for reviewers

Signed-off-by: zhaomenghuan [email protected]

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhaomenghuan thank you for the changes, please update and respect the pull-request template which informs developers and reviewers what the changes are about, how to test, etc, no matter how trivial the updates are.

@vince-fugnitto vince-fugnitto added bulk-edit issues related to the bulk-edit extension ui/ux issues related to user interface / user experience labels Feb 21, 2021
@vince-fugnitto
Copy link
Member

@zhaomenghuan are you still interested in contributing the changes?

@zhaomenghuan
Copy link
Contributor Author

@zhaomenghuan are you still interested in contributing the changes?

@vince-fugnitto I have updated the pull-request template.

@vince-fugnitto vince-fugnitto merged commit 7b14ec0 into eclipse-theia:master Jul 8, 2021
@vince-fugnitto vince-fugnitto added this to the 1.16.0 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bulk-edit issues related to the bulk-edit extension ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid unit "p" in bulk-edit.css
2 participants