Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid unit "p" in bulk-edit.css #9216

Closed
ahaWDY opened this issue Mar 18, 2021 · 1 comment · Fixed by #9100
Closed

Invalid unit "p" in bulk-edit.css #9216

ahaWDY opened this issue Mar 18, 2021 · 1 comment · Fixed by #9100
Labels
bulk-edit issues related to the bulk-edit extension css Issues related to CSS functionality good first issue good first issues for new contributors

Comments

@ahaWDY
Copy link
Contributor

ahaWDY commented Mar 18, 2021

Bug Description:

"1p" is likely to be a typo and should be "1px".

Steps to Reproduce:

theia/packages/bulk-edit/src/browser/style/bulk-edit.css

Line 65 in 9dacd49

border: 1p solid var(--theia-diffEditor-insertedTextBorder);

Additional Information

  • Operating System: Windows
  • Theia Version: 1.11.0
@vince-fugnitto vince-fugnitto added bulk-edit issues related to the bulk-edit extension css Issues related to CSS functionality good first issue good first issues for new contributors labels Mar 18, 2021
@kittaakos
Copy link
Contributor

Thank you, @ahaWDY. We have a PR for this: #9100

@vince-fugnitto vince-fugnitto mentioned this issue Jul 8, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bulk-edit issues related to the bulk-edit extension css Issues related to CSS functionality good first issue good first issues for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bulk-edit: fix spelling mistake in border value zhaomenghuan/theia
3 participants
@kittaakos @ahaWDY @vince-fugnitto