Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ip] pin jschardet to v1.6.0 #8353

Closed
wants to merge 1 commit into from
Closed

[ip] pin jschardet to v1.6.0 #8353

wants to merge 1 commit into from

Conversation

marcdumais-work
Copy link
Contributor

@marcdumais-work marcdumais-work commented Aug 11, 2020

What it does

Our jschardet has been stepped to a new major version and we missed
it. Since this dependency is licensed under the LGPL, it requires a
special permission from the Eclipse Board, before we are allowed
to use a new version, as part of a release.

There is only a bit more than 2 weeks before our next release, and
I do not know when the next board meeting may happen. So it looks
like we might have to delay the release or momentarily go back to
the previous, approved, dependency version.

This is what this PR does, using a resolution.

CQ (need to be committer to see):
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22481

How to test

Check that CI passes and that the example application still works correctly.

Review checklist

Reminder for reviewers

Our jschardet has been stepped to a new major version and we missed
it. Since this dependency is licensed under the LGPL, it requires a
special premission from the Eclipse Board, before we are allowed
to use a new version, as part of a release.

There is only a bit more than 2 weeks before our next release, and
I do not know when the next board meeting may happen. So it looks
like we might have to delay the relase or momentarily go back to
the previous, approved, dependency version.

This is what this PR does, using a resolution.

CQ (need to be committer to see):
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22481

Signed-off-by: Marc Dumais <[email protected]>
@marcdumais-work
Copy link
Contributor Author

I have reached-out to Sharon to let her know about this, in addition to opening a CQ for the new dependency version (see description). It looks very tight to have the new dependency version Board-approved by the end of the month, but we'll see what she says.

@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Aug 11, 2020
@marcdumais-work
Copy link
Contributor Author

This is not working. [email protected] does not have TS typings, while the newer 2.1.1 does.

I had assumed this was an update but it's a new use of jschardet, from @theia/core, that has never worked with older version. So more work would be needed to potentially make it work with v1.6.0.

@akosyakov as far as you know, once we get pass the typing issue, would the older jschardet likely work, as used in the encoding service?

@vince-fugnitto Can you watch what's happening with the CQ, and if it does not look that it will be approved in time for the August release, complete this PR and have it merged before release?

@marcdumais-work
Copy link
Contributor Author

marcdumais-work commented Aug 11, 2020

I have reached-out to Sharon to let her know about this, in addition to opening a CQ for the new dependency version (see description). It looks very tight to have the new dependency version Board-approved by the end of the month, but we'll see what she says.

Good news: the previous Eclipse Board approval for our use of jschardet was not version-specific, so we're still covered as far as getting the required special permission to use/distribute a LGPL-license dependency. So only the normal license checks are necessary to make sure the license has not changed in the meantime, which I hope will be relatively quick. (update: the Eclipse Foundation IP Team will do the check and update the CQ with their findings)

@akosyakov
Copy link
Member

@akosyakov as far as you know, once we get pass the typing issue, would the older jschardet likely work, as used in the encoding service?

probably, we will need to test

@marcdumais-work marcdumais-work deleted the jschardet branch November 8, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants