Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ip] jschardet dependency stepped to new major version #8389

Closed
marcdumais-work opened this issue Aug 14, 2020 · 2 comments
Closed

[ip] jschardet dependency stepped to new major version #8389

marcdumais-work opened this issue Aug 14, 2020 · 2 comments
Assignees
Labels
CQ Required (deprecated) issues requiring a CQ (contributor questionnaire)

Comments

@marcdumais-work
Copy link
Contributor

We pull a new major version of jschardet since recently, without having noticed. This dependency is special, since it's LGPL and required special Eclipse Board permission to use. The permission we got is still good, but a check by the IP team is required to make sure nothing license-related changed. I opened a CQ for this (need to be committer to see):

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22481

Hopefully the CQ can be approved before the release date. If not I think we'd need to delay the release or momentarily go back to the previously approved dependency version ([email protected] IIRC).

I gave it a quick try to pin the version using a resolutions block entry, but was unsuccessful - it looks like we'd need to add a TS typing for it, that's provided with the later version:
#8353 (comment)

@marcdumais-work marcdumais-work added the CQ Required (deprecated) issues requiring a CQ (contributor questionnaire) label Aug 14, 2020
@paul-marechal
Copy link
Member

Relevant change: 8bf15dc#diff-f4f412caa68d8fde92b3d6bd3c2b3be1R37

@vince-fugnitto
Copy link
Member

The CQ has been approved (per previous board exception), there is no further action required 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CQ Required (deprecated) issues requiring a CQ (contributor questionnaire)
Projects
None yet
Development

No branches or pull requests

3 participants