-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the leftover @theia/json
dependency.
#8182
Conversation
as well fixes some exceptions caused by disposed widgets Signed-off-by: Anton Kosyakov <[email protected]>
Signed-off-by: Anton Kosyakov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests currently fail but it might be unrelated, we can either restart the CI or open the changes on top of #8151 which make the api integration suite more robust and fixes other issues.
Smart 👍 I'll do that. |
Signed-off-by: Akos Kitta <[email protected]>
fe64969
to
30b7a14
Compare
Fine with me if tests are green. |
@kittaakos when the base was changed it looked like travis didn't start (since it was not based off |
Yes, I can confirm.
I'd leave the decision to @akosyakov. |
Signed-off-by: Akos Kitta [email protected]
NOTE: This PR was opened against #8151 and not the
master
.What it does
It removes the
@theia/json
dependency from the test. I am not sure if this PR makes any sense. Can you please look into it, @akosyakov? Thank you!Closes #8183
How to test
The CI should be green.
Review checklist
Reminder for reviewers