Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quality][json] Check why we depend on @theia/json in the TS tests #8183

Closed
kittaakos opened this issue Jul 16, 2020 · 2 comments
Closed

[quality][json] Check why we depend on @theia/json in the TS tests #8183

kittaakos opened this issue Jul 16, 2020 · 2 comments
Labels
json issues related to the json language quality issues related to code and application quality test issues related to unit and api tests

Comments

@kittaakos
Copy link
Contributor

Bug Description:

Follow-up of: #8181

Let's check why we have this in the code and how does the test pass?

.then(function () { return Promise.resolve(require('@theia/json/lib/node/json-backend-module')).then(load) })

Steps to Reproduce:

Additional Information

  • Operating System:
  • Theia Version:
@vince-fugnitto vince-fugnitto added json issues related to the json language quality issues related to code and application quality test issues related to unit and api tests labels Sep 1, 2020
@tsmaeder
Copy link
Contributor

tsmaeder commented May 7, 2021

@kittaakos you openend a PR that removes that dependency, but then close it. Can you comment why?

@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
json issues related to the json language quality issues related to code and application quality test issues related to unit and api tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants