Register editor to location stack when 'onCurrentEditorChanged' #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nged' Fixes #4388 - Previously, it wasn't clear when an editor would be registered to the `navigation location stack`. This change adds the missing registration of an editor when `onCurrentEditorChanged`. Results in the quick file open are now more consistently added to the stack. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added
bug
|
Tested on gitpod. Looks like i would have to mouse-click to activate the preview editor before seeing the file from the "recently opened". is that what we want ?
|
|
@elaihau just to clarify the change ensures that when an active editor is first opened, then it'll be registered in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4388
navigation location stack.This change adds the missing registration of an editor when
onCurrentEditorChanged. Results in the quick file open are now more consistently added to the stack.Signed-off-by: Vincent Fugnitto [email protected]