Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation-history] Includes bad 0,0 positions #5465

Closed
svenefftinge opened this issue Jun 14, 2019 · 4 comments
Closed

[navigation-history] Includes bad 0,0 positions #5465

svenefftinge opened this issue Jun 14, 2019 · 4 comments
Assignees

Comments

@svenefftinge
Copy link
Contributor

When navigating between editors using the navigation history I see 0,0 positions. Probably added by non-atomic editor open/reveal actions.

Reproduce:

  1. open file a
  2. go to declaration in file b
  3. press CTRL+- and see how you end up on line 0 in file b (expected file a)
@kittaakos
Copy link
Contributor

The editor.enablePreview: true preference further complicates this. The navigation is broken as we always open a new non-preview editor even if editor.enablePreview is true.

I try to fix both issues in one PR.

@kittaakos
Copy link
Contributor

This change causes the issue: #4423

@kittaakos
Copy link
Contributor

Also, #4423 did not handle the case when a file is opened from the navigator with a single click.
With a single click open, the selection is not set into the editor, hence the location will not be registered into the stack only double click does it. It works properly in VS Code.

@colin-grant-work
Copy link
Contributor

I believe that this particular problem was addressed by #9004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants