[GTK4] Implement correct moveAbove()/moveBelow() control behavior #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a little demo to illustrate how it behaves using Snippet6. Recording.webm |
ptziegler
force-pushed
the
gtk4-move-widgets
branch
from
2a577b4 to
ab2f941
Compare
ptziegler
force-pushed
the
gtk4-move-widgets
branch
2 times, most recently
from
d154c29 to
1c281f5
Compare
akurtakov
force-pushed
the
gtk4-move-widgets
branch
from
1c281f5 to
a436f57
Compare
Regardless of which control are given as input parameters, the controls are currently always added as last child to their parents. Underlying issue seems to be that the swt_fixed_restack() method does not handle the GTK4 widgets correctly. As a solution, perform the movement using the proper API. To understand the combination in which GTK methods need to be called, consider the expected behavior based on the GTK and SWT documentation: [GTK4 Documentation] - gtk_widget_insert_after(widget, parent, previous_sibling) It will be placed after previous_sibling, or at the beginning if previous_sibling is NULL. - gtk_widget_insert_before(widget, parent, next_sibling) It will be placed before next_sibling, or at the end if next_sibling is NULL. [SWT Documentation] - moveAbove(control) Moves the receiver above the specified control in the drawing order. If the argument is null, then the receiver is moved to the top of the drawing order This means that if the specified control is NULL, gtk_widget_insert_after(...) needs to be called, otherwise gtk_widget_insert_before(...). - moveBelow(control) Moves the receiver below the specified control in the drawing order. If the argument is null, then the receiver is moved to the bottom of the drawing order. Here the inverse applies. If the specified control is NULL, gtk_widget_insert_before(...) needs to be called, otherwise gtk_widget_insert_after(...).
ptziegler
force-pushed
the
gtk4-move-widgets
branch
from
a436f57 to
8f1f5be
Compare
|
Everything is green now. Unless there are any objections, I'll plan on merging this later today. |
Just go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of which control are given as input parameters, the controls are currently always added as last child to their parents. Underlying issue seems to be that the swt_fixed_restack() method does not handle the GTK4 widgets correctly. As a solution, perform the movement using the proper API.
To understand the combination in which GTK methods need to be called, consider the expected behavior based on the GTK and SWT documentation:
[GTK4 Documentation]
gtk_widget_insert_after(widget, parent, previous_sibling)
It will be placed after previous_sibling, or at the beginning if previous_sibling is NULL.
gtk_widget_insert_before(widget, parent, next_sibling)
It will be placed before next_sibling, or at the end if next_sibling is NULL.
[SWT Documentation]
moveAbove(control)
Moves the receiver above the specified control in the drawing order. If the argument is null, then the receiver is moved to the top of the drawing order
This means that if the specified control is NULL,
gtk_widget_insert_after(...) needs to be called, otherwise gtk_widget_insert_before(...).
moveBelow(control)
Moves the receiver below the specified control in the drawing order. If the argument is null, then the receiver is moved to the bottom of the drawing order.
Here the inverse applies. If the specified control is NULL, gtk_widget_insert_before(...) needs to be called, otherwise gtk_widget_insert_after(...).