-
Notifications
You must be signed in to change notification settings - Fork 150
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GTK4] Implement correct moveAbove()/moveBelow() control behavior
Regardless of which control are given as input parameters, the controls are currently always added as last child to their parents. Underlying issue seems to be that the swt_fixed_restack() method does not handle the GTK4 widgets correctly. As a solution, perform the movement using the proper API. To understand the combination in which GTK methods need to be called, consider the expected behavior based on the GTK and SWT documentation: [GTK4 Documentation] - gtk_widget_insert_after(widget, parent, previous_sibling) It will be placed after previous_sibling, or at the beginning if previous_sibling is NULL. - gtk_widget_insert_before(widget, parent, next_sibling) It will be placed before next_sibling, or at the end if next_sibling is NULL. [SWT Documentation] - moveAbove(control) Moves the receiver above the specified control in the drawing order. If the argument is null, then the receiver is moved to the top of the drawing order This means that if the specified control is NULL, gtk_widget_insert_after(...) needs to be called, otherwise gtk_widget_insert_before(...). - moveBelow(control) Moves the receiver below the specified control in the drawing order. If the argument is null, then the receiver is moved to the bottom of the drawing order. Here the inverse applies. If the specified control is NULL, gtk_widget_insert_before(...) needs to be called, otherwise gtk_widget_insert_after(...).
- Loading branch information
Showing
4 changed files
with
52 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters