-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #495 compile iceoryx on gcc 5 #512
Merged
dkroenke
merged 6 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#495-bugfix-compile-on-gcc-5
Jan 22, 2021
Merged
Iox #495 compile iceoryx on gcc 5 #512
dkroenke
merged 6 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#495-bugfix-compile-on-gcc-5
Jan 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
commented
Jan 21, 2021
iceoryx_posh/include/iceoryx_posh/internal/roudi/port_manager.hpp
Outdated
Show resolved
Hide resolved
elBoberido
reviewed
Jan 21, 2021
iceoryx_posh/include/iceoryx_posh/internal/roudi/port_manager.hpp
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/roudi/port_manager.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Dietrich Krönke <[email protected]>
elBoberido
approved these changes
Jan 21, 2021
This patch works for me! |
elfenpiff
approved these changes
Jan 22, 2021
@BH1SCW you're welcome. We cannot promise that we don't break it again, since we don't have a CI for GCC5. |
Never mind :) Maybe I will keep building the code from time to time. |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)Notes for Reviewer
@BH1SCW This is the PR for compiling iceoryx on GCC 5.4, please check out if it works on your side. Please note that i installed manually a newer CMake version on Ubuntu 16 for building.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References