Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #495 compile iceoryx on gcc 5 #512

Merged

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Jan 21, 2021

Pre-Review Checklist for the PR Author

  1. Branch follows the naming format (iox-#123-this-is-a-branch)
  2. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  3. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  4. Relevant issues are linked
  5. Add sensible notes for the reviewer
  6. All checks have passed
  7. Assign PR to reviewer

Notes for Reviewer

@BH1SCW This is the PR for compiling iceoryx on GCC 5.4, please check out if it works on your side. Please note that i installed manually a newer CMake version on Ubuntu 16 for building.

  • add namespace to SubscribeState in C-Binding
  • initialize NodeName_t in posh_runtime correctly
  • rework lambda in PortManager for capturing this instead of reference

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

  1. All checkboxes in the PR checklist are checked or crossed out
  2. Merge

References

@dkroenke dkroenke added the bugfix Solves a bug label Jan 21, 2021
@BH1SCW
Copy link
Contributor

BH1SCW commented Jan 21, 2021

This patch works for me!
All of you guys, I really thank you.

@dkroenke dkroenke added this to the Prio 1 milestone Jan 21, 2021
@dkroenke dkroenke merged commit fe2a65f into eclipse-iceoryx:master Jan 22, 2021
@dkroenke dkroenke deleted the iox-#495-bugfix-compile-on-gcc-5 branch January 22, 2021 11:09
@elBoberido
Copy link
Member

@BH1SCW you're welcome. We cannot promise that we don't break it again, since we don't have a CI for GCC5.

@BH1SCW
Copy link
Contributor

BH1SCW commented Jan 22, 2021

@BH1SCW you're welcome. We cannot promise that we don't break it again, since we don't have a CI for GCC5.

Never mind :) Maybe I will keep building the code from time to time.

@elBoberido elBoberido mentioned this pull request Feb 5, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail build on ubuntu 16.04 with g++ 5.4.0
4 participants