-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #521 best practice for testing #547
Merged
elBoberido
merged 11 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#521-best-practice-for-testing
Feb 12, 2021
Merged
Iox #521 best practice for testing #547
elBoberido
merged 11 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#521-best-practice-for-testing
Feb 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
There should be a link from https://github.com/eclipse-iceoryx/iceoryx/blob/master/CONTRIBUTING.md#testing to this document. |
marthtz
reviewed
Feb 5, 2021
dkroenke
reviewed
Feb 5, 2021
elBoberido
commented
Feb 5, 2021
dkroenke
reviewed
Feb 8, 2021
19 tasks
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
dkroenke
previously approved these changes
Feb 9, 2021
MatthiasKillat
previously approved these changes
Feb 10, 2021
19 tasks
Signed-off-by: Mathias Kraus <[email protected]>
e99e4be
dkroenke
previously approved these changes
Feb 11, 2021
Signed-off-by: Mathias Kraus <[email protected]>
dkroenke
approved these changes
Feb 12, 2021
FerdinandSpitzschnueffler
approved these changes
Feb 12, 2021
elfenpiff
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)Notes for Reviewer
This PR tries to document the our best practices to write tests for iceoryx. Some of them were unwritten, making it hard for new contributor to write test the way we expect it.
I still have to write a small example for typed and parameterized test, but this will be more or less just a template for c&p and all the other stuff is done and can be reviewed.
Oh, and I fixed a typo from my last PR.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References