-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox 1942 introduce further semantic string types #1951
Merged
elfenpiff
merged 16 commits into
eclipse-iceoryx:master
from
ApexAI:iox-1942-introduce-further-semantic-string-types
Apr 4, 2023
Merged
Iox 1942 introduce further semantic string types #1951
elfenpiff
merged 16 commits into
eclipse-iceoryx:master
from
ApexAI:iox-1942-introduce-further-semantic-string-types
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
98e765b
to
cb603b1
Compare
…hangelog Signed-off-by: Christian Eltzschig <[email protected]>
b57a698
to
dff4208
Compare
Codecov Report
@@ Coverage Diff @@
## master #1951 +/- ##
==========================================
+ Coverage 75.51% 75.53% +0.02%
==========================================
Files 388 392 +4
Lines 15276 15330 +54
Branches 2158 2181 +23
==========================================
+ Hits 11536 11580 +44
+ Misses 3067 3066 -1
- Partials 673 684 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…s since a group-name may have different contracts with syntax, length and style Signed-off-by: Christian Eltzschig <[email protected]>
iceoryx_hoofs/test/moduletests/test_vocabulary_semantic_string.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
reviewed
Apr 3, 2023
iceoryx_hoofs/test/moduletests/test_vocabulary_semantic_string.cpp
Outdated
Show resolved
Hide resolved
iceoryx_hoofs/test/moduletests/test_vocabulary_semantic_string.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
… better semantic context Signed-off-by: Christian Eltzschig <[email protected]>
7c31501
to
404204d
Compare
elBoberido
previously approved these changes
Apr 3, 2023
} | ||
|
||
return false; | ||
return (c == internal::ASCII_DASH || (internal::ASCII_0 <= c && c <= internal::ASCII_9)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This puts a smile on Walter E. Brown's face :)
Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
previously approved these changes
Apr 3, 2023
…cked_at Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
approved these changes
Apr 3, 2023
FerdinandSpitzschnueffler
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References