Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox 1942 introduce further semantic string types #1951

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Mar 31, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff elfenpiff self-assigned this Mar 31, 2023
@elfenpiff elfenpiff force-pushed the iox-1942-introduce-further-semantic-string-types branch from 98e765b to cb603b1 Compare March 31, 2023 15:20
@elfenpiff elfenpiff force-pushed the iox-1942-introduce-further-semantic-string-types branch from b57a698 to dff4208 Compare March 31, 2023 15:26
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #1951 (4a00712) into master (207d419) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
+ Coverage   75.51%   75.53%   +0.02%     
==========================================
  Files         388      392       +4     
  Lines       15276    15330      +54     
  Branches     2158     2181      +23     
==========================================
+ Hits        11536    11580      +44     
+ Misses       3067     3066       -1     
- Partials      673      684      +11     
Flag Coverage Δ
unittests 75.19% <80.00%> (+0.02%) ⬆️
unittests_timing 15.32% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/vocabulary/include/iox/string.hpp 100.00% <ø> (ø)
...ceoryx_hoofs/posix/vocabulary/source/user_name.cpp 85.71% <66.66%> (ø)
...ceoryx_hoofs/posix/vocabulary/source/file_name.cpp 71.42% <71.42%> (ø)
...ceoryx_hoofs/posix/vocabulary/source/file_path.cpp 80.00% <80.00%> (ø)
...eoryx_hoofs/posix/vocabulary/source/group_name.cpp 85.71% <85.71%> (ø)
iceoryx_hoofs/posix/vocabulary/source/path.cpp 100.00% <100.00%> (ø)
...ryx_hoofs/vocabulary/include/iox/detail/string.inl 98.42% <100.00%> (-0.38%) ⬇️

... and 2 files with indirect coverage changes

…s since a group-name may have different contracts with syntax, length and style

Signed-off-by: Christian Eltzschig <[email protected]>
@elfenpiff elfenpiff force-pushed the iox-1942-introduce-further-semantic-string-types branch from 7c31501 to 404204d Compare April 3, 2023 16:39
@elfenpiff elfenpiff requested a review from elBoberido April 3, 2023 16:39
elBoberido
elBoberido previously approved these changes Apr 3, 2023
}

return false;
return (c == internal::ASCII_DASH || (internal::ASCII_0 <= c && c <= internal::ASCII_9));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts a smile on Walter E. Brown's face :)

Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
elBoberido previously approved these changes Apr 3, 2023
@elfenpiff elfenpiff merged commit 85de9bd into eclipse-iceoryx:master Apr 4, 2023
@elfenpiff elfenpiff deleted the iox-1942-introduce-further-semantic-string-types branch April 4, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strong string types
3 participants