Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strong string types #1942

Closed
1 of 2 tasks
elfenpiff opened this issue Mar 17, 2023 · 0 comments · Fixed by #1943 or #1951
Closed
1 of 2 tasks

Strong string types #1942

elfenpiff opened this issue Mar 17, 2023 · 0 comments · Fixed by #1943 or #1951
Assignees
@elfenpiff

Comments

@elfenpiff
Copy link
Contributor

elfenpiff commented Mar 17, 2023 •
edited by elBoberido
Loading

Brief feature description

In multiple constructs we use a iox::string to represent a posix user/group, filename, path, filepath etc. This leads to a lot of code duplication since the validity of the string has to be verified on multiple levels multiple times.
Furthermore, it makes it unclear to the user what kind of string-type is required and what restriction/contract it shall follow.

Detailed information

  • Introduce a SemanticString based on a iox::String which is used as base for strings with a contract.
  • Implement User, Group, FileName, FilePath, Path as semantic strings.
@elfenpiff elfenpiff self-assigned this Mar 17, 2023
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 17, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Introduce semantic string
4383d12
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 17, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Introduce UserName
94782aa
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 17, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add tests to verify creation of the semantic…
9f78b68 
… string
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Finalize tests for semantic string
ad87849
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add documentation to the semantic string
4868ef7
@elfenpiff elfenpiff mentioned this issue Mar 20, 2023
Merged
21 tasks
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Update release notes
f5d4e03
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Update release notes
b15cf56
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Suppress array to pointer decay warning
71ca4f0
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Fix compiler problems in Windows with unit test
4af85f4
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Adjust Bazel build to new posix vocabulary t…
7faa2fe 
…ypes
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Solve syntax issue of gcc/clang compiler
9ecf0d3
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add comparision operators and test them
07e3671
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add documentation to the semantic string ope…
4e73add 
…rators
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 20, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Update code example in documentation
6b53565
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 22, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Fix typos in documentation
df50634 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 22, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Downgrade logging to debug, fix further typos
72545a4 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 22, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add header for string types
484fa20 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add missing test cases
73fc853 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Implement and test FileName
80cc451 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Fix clang-tidy warning by adding const
d71aa91 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Implement and test GroupName
35c3b4c 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Implement and test FilePath
2e015e9 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Fix clang-tidy warning by adding const
e32e5e6 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add tests to verify invalid content creation
c15a449 
Signed-off-by: Christian Eltzschig <[email protected]>
@elfenpiff elfenpiff reopened this Mar 27, 2023
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add tests for path
98e765b 
Signed-off-by: Christian Eltzschig <[email protected]>
@elfenpiff elfenpiff mentioned this issue Mar 31, 2023
Merged
21 tasks
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add header for string types
fa41e02 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Implement and test FileName
af72627 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Implement and test GroupName
94d410d 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Implement and test FilePath
e50fbfa 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add tests for path
84516f2 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Integrate newest master
cb603b1 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add FileName, Path, PathName, GroupName to c…
b57a698 
…hangelog

Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 31, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add FileName, Path, PathName, GroupName to c…
dff4208 
…hangelog

Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add explicit group name verificator function…
efb1a62 
…s since a group-name may have different contracts with syntax, length and style

Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942: Fix group tests for freebsd platform
20d3cf0 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Clang-format
41a4e37 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Adjust release notes
7b7cf02 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add unchecked_at method
84d9f09 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Add description for all semantic strings
59e29aa 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Use ascii constexpr and rename variables for…
404204d 
… better semantic context

Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Adjust test id
c2057b1 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 3, 2023
@elfenpiff
iox-eclipse-iceoryx#1942 Correct forwarding to const version of unche…
4a00712 
…cked_at

Signed-off-by: Christian Eltzschig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@elfenpiff