iox-#692 Move tsan jobs into build-test.yml

[ibrhmkuru]

Signed-off-by: Ibrahim Kuru [email protected]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
11. Assign PR to reviewer

Notes for Reviewer

• build-test-ubuntu-with-thread-sanitizer-clang-latest job moved from Code Linting on master branch workflow into Build & Test workflow. So, thread sanitizer will work for every pull request.
• Suppression file refined. For mutex and deadlock type of warnings, only the problematic functions are suppressed.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Relates ThreadSanitizer for iceoryx #692

[dkroenke]

This needs to wait until #1879 got merged to re-evaluate the scan time.

[elBoberido]

@ibrhmkuru It seems the tsan job now finishes in about 23 minutes. https://github.com/eclipse-iceoryx/iceoryx/actions/runs/4165393238/jobs/7208329322. I think we do not need to split the test runs up.

cc @dkroenke

[dkroenke]

@ibrhmkuru The job itself looks good and the execution time is acceptable, we can bring this into master.

There are only some formal things missing:

• rebase the branch onto latest master and drop merge commit d58e0d2 and resolve merge conflicts
• squash remaining commits into one
• the commits and the Pull-Request needs to be linked to issue ThreadSanitizer for iceoryx #692
• the commits need to be signed off
• Fill out the Pull-Request Checklist

[dkroenke]

Scan time looks ok with ~25 minutes.

The error in the integrationtest is caused by another issue and will be fixed with #1907

LGTM!

[codecov]

Codecov Report

Merging #1888 (002c083) into master (2f87030) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1888      +/-   ##
==========================================
+ Coverage   75.44%   75.45%   +0.01%     
==========================================
  Files         383      383              
  Lines       15181    15181              
  Branches     2148     2148              
==========================================
+ Hits        11453    11455       +2     
  Misses       3055     3055              
+ Partials      673      671       -2     

Flag	Coverage Δ
unittests	75.11% <ø> (+0.01%)	⬆️
unittests_timing	15.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp	87.87% <0.00%> (+6.06%)	⬆️

[ibrhmkuru]

@dkroenke Can you approve if changes are okay ?

[ibrhmkuru]

@dkroenke Do you have any additional review comments?

[dkroenke]

LGTM