-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox 1960 update integrationtests #1907
Merged
dkroenke
merged 5 commits into
eclipse-iceoryx:master
from
ApexAI:iox-1960-update-integrationtests
Feb 21, 2023
Merged
Iox 1960 update integrationtests #1907
dkroenke
merged 5 commits into
eclipse-iceoryx:master
from
ApexAI:iox-1960-update-integrationtests
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 383 383
Lines 15181 15181
Branches 2148 2148
=======================================
+ Hits 11453 11454 +1
Misses 3055 3055
+ Partials 673 672 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mossmaurice
previously approved these changes
Feb 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a few nitpicks.
dkroenke
force-pushed
the
iox-1960-update-integrationtests
branch
5 times, most recently
from
February 20, 2023 13:37
ec9cd4d
to
cc67b87
Compare
FerdinandSpitzschnueffler
previously approved these changes
Feb 20, 2023
mossmaurice
previously approved these changes
Feb 20, 2023
dkroenke
dismissed stale reviews from mossmaurice and FerdinandSpitzschnueffler
via
February 20, 2023 16:55
2dcee1d
mossmaurice
previously approved these changes
Feb 20, 2023
FerdinandSpitzschnueffler
previously approved these changes
Feb 20, 2023
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke
dismissed stale reviews from FerdinandSpitzschnueffler and mossmaurice
via
February 21, 2023 07:45
dcdcaff
dkroenke
force-pushed
the
iox-1960-update-integrationtests
branch
from
February 21, 2023 07:45
2dcee1d
to
dcdcaff
Compare
FerdinandSpitzschnueffler
approved these changes
Feb 21, 2023
elfenpiff
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References