Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox 1960 update integrationtests #1907

Merged

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Feb 17, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@dkroenke dkroenke added the tooling All iceoryx related tooling (scripts etc.) label Feb 17, 2023
@dkroenke dkroenke self-assigned this Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1907 (dcdcaff) into master (2f87030) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1907   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files         383      383           
  Lines       15181    15181           
  Branches     2148     2148           
=======================================
+ Hits        11453    11454    +1     
  Misses       3055     3055           
+ Partials      673      672    -1     
Flag Coverage Δ
unittests 75.10% <ø> (+<0.01%) ⬆️
unittests_timing 15.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 84.84% <0.00%> (+3.03%) ⬆️

mossmaurice
mossmaurice previously approved these changes Feb 18, 2023
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a few nitpicks.

iceoryx_integrationtest/CMakeLists.txt Outdated Show resolved Hide resolved
iceoryx_integrationtest/CMakeLists.txt Outdated Show resolved Hide resolved
iceoryx_integrationtest/package.xml Show resolved Hide resolved
@dkroenke dkroenke force-pushed the iox-1960-update-integrationtests branch 5 times, most recently from ec9cd4d to cc67b87 Compare February 20, 2023 13:37
@dkroenke dkroenke requested a review from mossmaurice February 20, 2023 13:43
mossmaurice
mossmaurice previously approved these changes Feb 20, 2023
mossmaurice
mossmaurice previously approved these changes Feb 20, 2023
@dkroenke dkroenke force-pushed the iox-1960-update-integrationtests branch from 2dcee1d to dcdcaff Compare February 21, 2023 07:45
@dkroenke dkroenke merged commit adbab34 into eclipse-iceoryx:master Feb 21, 2023
@dkroenke dkroenke deleted the iox-1960-update-integrationtests branch February 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrationtest CI job failing
4 participants