Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-605 Introduce memory namespace #1677

Merged

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Sep 27, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

  • Rename directory from reloctable_pointer to memory
  • Rename namespace rp to memory

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Sep 27, 2022
@mossmaurice mossmaurice self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1677 (d904a60) into master (908b7e9) will decrease coverage by 0.02%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1677      +/-   ##
==========================================
- Coverage   76.20%   76.18%   -0.03%     
==========================================
  Files         365      366       +1     
  Lines       14160    14164       +4     
  Branches     2361     2361              
==========================================
  Hits        10791    10791              
- Misses       2580     2581       +1     
- Partials      789      792       +3     
Flag Coverage Δ
unittests 75.84% <90.32%> (-0.03%) ⬇️
unittests_timing 15.59% <8.06%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eoryx_dust/relocatable_pointer/relocatable_ptr.inl 0.00% <ø> (ø)
...clude/iceoryx_hoofs/internal/concurrent/loffli.hpp 100.00% <ø> (ø)
...eoryx_hoofs/internal/memory/pointer_repository.hpp 100.00% <ø> (ø)
...iceoryx_hoofs/internal/memory/relative_pointer.hpp 100.00% <ø> (ø)
...yx_hoofs/internal/memory/relative_pointer_data.hpp 100.00% <ø> (ø)
...yx_hoofs/internal/memory/relative_pointer_data.inl 60.00% <ø> (ø)
...urce/relocatable_pointer/relative_pointer_data.cpp 100.00% <ø> (ø)
...clude/iceoryx_posh/internal/mepoo/shared_chunk.hpp 100.00% <ø> (ø)
...x_posh/internal/mepoo/shm_safe_unmanaged_chunk.hpp 100.00% <ø> (ø)
...ceoryx_posh/internal/popo/ports/base_port_data.hpp 100.00% <ø> (ø)
... and 32 more

@mossmaurice mossmaurice force-pushed the iox-605-introduce-memory-namespace branch from a3cc12a to 8a03aa8 Compare September 28, 2022 11:54
@mossmaurice mossmaurice force-pushed the iox-605-introduce-memory-namespace branch from 8a03aa8 to e3d3cf8 Compare September 28, 2022 12:21
@mossmaurice mossmaurice force-pushed the iox-605-introduce-memory-namespace branch from e3d3cf8 to 5885e26 Compare September 29, 2022 08:21
@mossmaurice mossmaurice merged commit 70b7183 into eclipse-iceoryx:master Oct 4, 2022
@mossmaurice mossmaurice deleted the iox-605-introduce-memory-namespace branch October 4, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Relocatable Pointer and Relative Pointer
3 participants