-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Relocatable Pointer and Relative Pointer #605
Closed
18 tasks done
Labels
documentation
Improvements or additions to documentation
globex
refactoring
Refactor code without adding features
test
A module/integration/stress/etc test for a component
Milestone
Comments
elfenpiff
added
documentation
Improvements or additions to documentation
refactoring
Refactor code without adding features
test
A module/integration/stress/etc test for a component
labels
Mar 11, 2021
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 11, 2021
…ptr_t Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 12, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 15, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 15, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 17, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 17, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 17, 2021
…locatable-ptr Signed-off-by: Marika Lehmann <[email protected]>
19 tasks
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 17, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 18, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 18, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 18, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 19, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 19, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 19, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 19, 2021
Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 19, 2021
…oSegment c'tor Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 19, 2021
…ool c'tor Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 22, 2021
…locatable-ptr Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 24, 2021
…locatable-ptr Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
changed the title
Cleanup Relocatable Pointer
Refactor Relocatable Pointer
Mar 24, 2021
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 24, 2021
… files Signed-off-by: Marika Lehmann <[email protected]>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Mar 24, 2021
…locatable-ptr Signed-off-by: Marika Lehmann <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
…erIfIdIsFree' Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
…tivePointer' Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
…module Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
…se note entry Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 29, 2022
…se note entry Signed-off-by: Simon Hoinkis <[email protected]>
22 tasks
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Oct 5, 2022
…include directory Signed-off-by: Simon Hoinkis <[email protected]>
22 tasks
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Oct 5, 2022
…include directory Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Oct 6, 2022
…include directory Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
that referenced
this issue
Oct 6, 2022
iox-#605 Move `RelativePointer` from internal to public include directory
Moved open tasks to #1745 |
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Oct 14, 2022
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/iceoryx
that referenced
this issue
Oct 17, 2022
Signed-off-by: Simon Hoinkis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
globex
refactoring
Refactor code without adding features
test
A module/integration/stress/etc test for a component
Brief feature description
The relocatable pointer (
iceoryx_utils/internal/relocatable_pointer
) implementation needs to be cleaned up:size_t
withuint64_t
(done in Iox #605 cleanup relocatable ptr #618 except making parameters const)iox::rp
where everything is stored (Iox #605 cleanup relocatable ptr #618)restructure the unit tests / add missing testsMoved to RestructureRelativePointer
unit tests #1745consider removingptr_t
andconst_ptr_t
aliases and usevoid*
directly (see Iox #605 cleanup relocatable ptr #618 (comment))add-> Not implemented asvoid* get() noexcept
,const void* get() const noexcept
,void* getBasePtr() noexcept
andconst void* getBasePtr() const noexcept
to BaseRelativePointerSharedPointer
usesget() const noexcept
consider changing return type of- Note: maybe not, it might be useful to have an indication whether the deregistration was successfulPointerRepository::unregisterPrt()
tovoid
(see Iox #605 cleanup relocatable ptr #618 (comment))PointerRepository::registerPtr()
methods if both are needed (see Iox #605 cleanup relocatable ptr #618 (comment)) + consider returning acxx::unique_ptr<id_t>
add const methods to RelativePointer (see Iox #605 cleanup relocatable ptr #618 (comment), Iox #605 cleanup relocatable ptr #618 (comment) and Iox #605 cleanup relocatable ptr #618 (comment)).This might not be needed, compare with e.g. std::shared_pointer https://en.cppreference.com/w/cpp/memory/shared_ptr/operator* It should work similar to STL smart pointers.other
move c'tor and move assignment operator of BaseRelocatablePointer (see Iox #605 cleanup relocatable ptr #618 (comment) and Iox #605 cleanup relocatable ptr #618 (comment))replaceMoved to RestructureRelativePointer
byRelocatablePointer
where applicable, e.g.Semaphore
andLoFFLi
RelativePointer
unit tests #1745RelativePointer
to public includeThe text was updated successfully, but these errors were encountered: