Iox #32 Mac OS fully supported #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… needed ArgvInspector Signed-off-by: Christian Eltzschig <[email protected]>
…o iox-eclipse-iceoryx#32-unit-tests-for-mac
Signed-off-by: Christian Eltzschig <[email protected]>
…me reimplementation Signed-off-by: Christian Eltzschig <[email protected]>
…rouplist implementation Signed-off-by: Christian Eltzschig <[email protected]>
…tible with the message queue Signed-off-by: Christian Eltzschig <[email protected]>
…on mac os and adjusted unit tests Signed-off-by: Christian Eltzschig <[email protected]>
…domain sockets Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
…a central position for all of them Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
…inux when sending message to destroyed socket - fixed Signed-off-by: Christian Eltzschig <[email protected]>
…behavior instead Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
…xist Signed-off-by: Christian Eltzschig <[email protected]>
…hores with empty name are not allowed Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
…sing sockets and since mac os uses sockets they are commented out for apple Signed-off-by: Christian Eltzschig <[email protected]>
…ligned memory Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Karsten1987
reviewed
Jun 15, 2020
There was a problem hiding this comment.
This doesn't compile for me:
--- stderr: iceoryx_utils
/Users/karsten/workspace/ros2/iceoryx_ws/osx/src/iceoryx/iceoryx_utils/source/posix_wrapper/timer.cpp:65:15: warning: result of comparison of constant 16777215 with expression of type 'unsigned char' is always false [-Wtautological-constant-out-of-range-compare]
if (index >= Timer::OsTimerCallbackHandle::MAX_DESCRIPTOR_VALUE)
~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
-- Build files have been written to: /Users/karsten/workspace/ros2/iceoryx_ws/osx/build/icedelivery
CMake Error at CMakeLists.txt:30 (find_package):
Could not find a package configuration file provided by
"CycloneDDS_CXX_API" with any of the following names:
CycloneDDS_CXX_APIConfig.cmake
cyclonedds_cxx_api-config.cmake
Add the installation prefix of "CycloneDDS_CXX_API" to CMAKE_PREFIX_PATH or
set "CycloneDDS_CXX_API_DIR" to a directory containing one of the above
files. If "CycloneDDS_CXX_API" provides a separate development package or
SDK, be sure it has been installed.
-- Configuring incomplete, errors occurred!
See also "/Users/karsten/workspace/ros2/iceoryx_ws/osx/build/iceoryx_dds_gateway/CMakeFiles/CMakeOutput.log".
--- stderr: iceoryx_dds_gateway
-- Found Curses: /usr/lib/libcurses.dylib
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LIB_TINFO
linked by target "iceoryx_introspection" in directory /Users/karsten/workspace/ros2/iceoryx_ws/osx/src/iceoryx/tools/introspection
-- Configuring incomplete, errors occurred!
See also "/Users/karsten/workspace/ros2/iceoryx_ws/osx/build/iceoryx_introspection/CMakeFiles/CMakeOutput.log".
--- stderr: iceoryx_introspection
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LIB_TINFO
linked by target "iceoryx_introspection" in directory /Users/karsten/workspace/ros2/iceoryx_ws/osx/src/iceoryx/tools/introspection
---
Aborted <<< iceoryx_introspection
iceoryx_utils/include/iceoryx_utils/internal/posix_wrapper/argv_inspection.hpp
Outdated
Show resolved
Hide resolved
mossmaurice
requested changes
Jun 20, 2020
…edAlloc/alignedFree and fixed several review findings Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
reviewed
Jun 23, 2020
| @@ -83,6 +115,8 @@ UnixDomainSocket& UnixDomainSocket::operator=(UnixDomainSocket&& other) noexcept | |||
| m_channelSide = std::move(other.m_channelSide); | |||
| m_sockfd = std::move(other.m_sockfd); | |||
| m_sockAddr = std::move(other.m_sockAddr); | |||
| m_isInitialized = std::move(other.m_isInitialized); | |||
There was a problem hiding this comment.
this is addressed in #151, together with the destroy method
dkroenke
reviewed
Jun 24, 2020
iceoryx_utils/include/iceoryx_utils/internal/concurrent/lockfree_queue/index_queue.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Christian Eltzschig <[email protected]>
…ing test. created cpp file for timing tests Signed-off-by: Christian Eltzschig <[email protected]>
… constructing from std::chrono Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elBoberido
requested changes
Jun 25, 2020
… and added COLCON_IGNORE in dds gateway Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
previously approved these changes
Jun 25, 2020
…IX to not use iceoryx Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido
approved these changes
Jun 25, 2020
mossmaurice
approved these changes
Jun 25, 2020
MatthiasKillat
pushed a commit
to MatthiasKillat/iceoryx
that referenced
this pull request
Jul 1, 2020
…sts-for-mac Iox eclipse-iceoryx#32 Mac OS fully supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.