Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS support #32

Closed
budrus opened this issue Jan 15, 2020 · 3 comments · Fixed by #69
Closed

macOS support #32

budrus opened this issue Jan 15, 2020 · 3 comments · Fixed by #69
Assignees
@elfenpiff
Labels
enhancement New feature

Comments

@budrus
Copy link
Contributor

budrus commented Jan 15, 2020 •
edited
Loading

Brief feature description

Having the possibility to use iceoryx on macOS

Detailed information

Needed for ROS2 tier 1 support
ROS2 Tiers
@budrus budrus added the enhancement New feature label Jan 15, 2020
marthtz added a commit to marthtz/iceoryx that referenced this issue Jan 29, 2020
@marthtz
iox-eclipse-iceoryx#32 Disable ACL for now
f159af5 
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
marthtz added a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@marthtz
iox-eclipse-iceoryx#32 Fix mutex defines for macOS
eb551e9 
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
budrus pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
iox-eclipse-iceoryx#32: system includes first files
18034d7
budrus pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
iox-eclipse-iceoryx#32: moved platform types
daeb790
elBoberido pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@marthtz @elBoberido
iox-eclipse-iceoryx#32 Disable ACL for now
e288d06 
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
elBoberido pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@marthtz @elBoberido
iox-eclipse-iceoryx#32 Fix mutex defines for macOS
901b396 
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
elBoberido pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@elBoberido
iox-eclipse-iceoryx#32: system includes first files
da51fe9
elBoberido pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@elBoberido
iox-eclipse-iceoryx#32: moved platform types
01b4da2
budrus pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
Merge branch 'iox-eclipse-iceoryx#32-add-macos-support' of https://gi…
efd0b8a 
…thub.com/marthtz/iceoryx into iox-eclipse-iceoryx#32-add-macos-support
budrus pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
iox-eclipse-iceoryx#32: redirected first headers for linux
568d381
elBoberido added a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@elBoberido
iox-eclipse-iceoryx#32 add COLCON_IGNORE
f48a47f 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elBoberido added a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@elBoberido
iox-eclipse-iceoryx#32 add preliminary platform detection
89d9585
budrus pushed a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
iox-eclipse-iceoryx#32 added system include dummys
f6f2c17
elBoberido added a commit to marthtz/iceoryx that referenced this issue Jan 30, 2020
@elBoberido
iox-eclipse-iceoryx#32 use platform detection for platform specific i…
50f515b 
…ncludes and libraries
@marthtz
Copy link
Contributor

marthtz commented Jan 31, 2020 •
edited by elfenpiff
Loading

Tasks for macOS support:

  • ACL needs to be adapted to macOS
  • Semaphore sem_timedwait() not available and needs to be created
  • Implement new OS timer based on "dispatch source"
  • Replace message queues with socket communication
  • Replace or find appropriate RT library if necessary
  • Modify pthread_setname_np() calls
  • Resolve type conflicts for cxx::align in
    • requiredManagementMemorySize()
    • requiredManagementMemorySize()
    • requiredManagementMemorySize()
    • Allocator::allocate()
  • Resolve type conflict for gid_t in PosixUser::getGroups()
  • Resolve type conflict for wprintw() in printProcessIntrospectionData()

elBoberido added a commit to marthtz/iceoryx that referenced this issue Jan 31, 2020
@elBoberido
iox-eclipse-iceoryx#32 use correct platform defines
4f93bca
@budrus
Copy link
Contributor Author

budrus commented Jan 31, 2020

I guess we start without acl or a replacement for it. Having different access groups on macOS is low prio

elfenpiff added a commit to marthtz/iceoryx that referenced this issue Feb 2, 2020
@elfenpiff
iox-eclipse-iceoryx#32 added empty functions, defines so that iceoryx…
7580c1e 
… at least compiles in windows; next step: implement empty function if possible
elfenpiff added a commit to marthtz/iceoryx that referenced this issue Feb 2, 2020
@elfenpiff
iox-eclipse-iceoryx#32 uncommented access_control implementation
628911a
elfenpiff added a commit to marthtz/iceoryx that referenced this issue Feb 2, 2020
@elfenpiff
iox-eclipse-iceoryx#32 added basic windows semaphore functions - but …
a653739 
…it is not complete
budrus pushed a commit to marthtz/iceoryx that referenced this issue Feb 2, 2020
iox-eclipse-iceoryx#32: ipc channel abstraction for UDS
4367f90
budrus pushed a commit to marthtz/iceoryx that referenced this issue Feb 3, 2020
iox-eclipse-iceoryx#32 first unix domain socket functionality
2aa7def
elfenpiff added a commit to marthtz/iceoryx that referenced this issue Feb 3, 2020
@elfenpiff
iox-eclipse-iceoryx#32 added hints for windows shared memory
5b7576c
elfenpiff added a commit to marthtz/iceoryx that referenced this issue Feb 3, 2020
@elfenpiff
Merge branch 'iox-eclipse-iceoryx#32-add-macos-support' of github.com…
bc655d2 
…:marthtz/iceoryx into iox-eclipse-iceoryx#32-add-macos-support
elBoberido added a commit to marthtz/iceoryx that referenced this issue Feb 3, 2020
@elBoberido
iox-eclipse-iceoryx#32 use the message queue from the posix wrapper i…
d07ca86 
…nstead of the posix mq_* calls
budrus pushed a commit to marthtz/iceoryx that referenced this issue Feb 3, 2020
iox-eclipse-iceoryx#32: timed methods for unix domian socket
6af31ae
elBoberido added a commit to marthtz/iceoryx that referenced this issue Feb 4, 2020
@elBoberido
iox-eclipse-iceoryx#32 make some mq_interface tests work and small me…
b29cf77 
…ssage_queue refactoring

Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elBoberido added a commit to marthtz/iceoryx that referenced this issue Feb 4, 2020
@elBoberido
iox-eclipse-iceoryx#32 refactor message queue existance check and add…
85f2e88 
…ed static unlink function

Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elfenpiff
iox-eclipse-iceoryx#32 mepoo shared memory creation test is now a tim…
a72b012 
…ing test. created cpp file for timing tests

Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elfenpiff
iox-eclipse-iceoryx#32 fixed issue with negative Duration values when…
1dea2bc 
… constructing from std::chrono

Signed-off-by: Christian Eltzschig <[email protected]>
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Jun 25, 2020
@elBoberido
iox-eclipse-iceoryx#32 adjust CMakeLists.txt to be able to use cmake 3.5
3185030
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Jun 25, 2020
@elBoberido
iox-eclipse-iceoryx#32 cleanup build structure
bd50724 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Jun 25, 2020
@elBoberido
iox-eclipse-iceoryx#32 fix cpptoml and googletest build on windows
f883493 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elfenpiff pushed a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elBoberido @elfenpiff
iox-eclipse-iceoryx#32 adjust CMakeLists.txt to be able to use cmake 3.5
da6d31e 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elfenpiff pushed a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elBoberido @elfenpiff
iox-eclipse-iceoryx#32 cleanup build structure
199aa63 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elfenpiff pushed a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elBoberido @elfenpiff
iox-eclipse-iceoryx#32 fix cpptoml and googletest build on windows
cb6c68e 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <[email protected]>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elfenpiff
iox-eclipse-iceoryx#32 added license header, adjusted paths in readme…
ceccf1f 
… and added COLCON_IGNORE in dds gateway

Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elfenpiff
iox-eclipse-iceoryx#32 removing iceoryx prefix again ...
16c040d 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elfenpiff
iox-eclipse-iceoryx#32 disabled stress tests
ce11042 
Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Jun 25, 2020
@elfenpiff
iox-eclipse-iceoryx#32 merging with master and reverting PROJECT_PREF…
0fc970a 
…IX to not use iceoryx

Signed-off-by: Christian Eltzschig <[email protected]>
mossmaurice added a commit that referenced this issue Jun 25, 2020
@mossmaurice
Merge pull request #138 from elfenpiff/iox-#32-unit-tests-for-mac
5dcc139 
Iox #32 Mac OS fully supported
@elfenpiff
Copy link
Contributor

Mac OS works!

MatthiasKillat pushed a commit to MatthiasKillat/iceoryx that referenced this issue Jul 1, 2020
@elfenpiff @orecham
iox-eclipse-iceoryx#32 merging with master and reverting PROJECT_PREF…
b9129d2 
…IX to not use iceoryx

Signed-off-by: Christian Eltzschig <[email protected]>
MatthiasKillat pushed a commit to MatthiasKillat/iceoryx that referenced this issue Jul 1, 2020
@mossmaurice @orecham
Merge pull request eclipse-iceoryx#138 from elfenpiff/iox-#32-unit-te…
3883639 
…sts-for-mac

Iox eclipse-iceoryx#32 Mac OS fully supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iox #32 implement posix timer and introduced timing test elfenpiff/iceoryx
3 participants
@marthtz @budrus @elfenpiff