Iox #299 fix clang tidy warnings

[elfenpiff]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

I disabled all clang-tidy warnings which are currently active in iceoryx, except naming. Those I fixed right away.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Clang-Tidy integration #299

[codecov]

Codecov Report

Merging #1175 (45e7f2b) into master (acad134) will increase coverage by 0.17%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #1175      +/-   ##
==========================================
+ Coverage   78.78%   78.95%   +0.17%     
==========================================
  Files         366      366              
  Lines       14616    14589      -27     
  Branches     2042     2042              
==========================================
+ Hits        11515    11519       +4     
+ Misses       2436     2402      -34     
- Partials      665      668       +3     

Flag	Coverage Δ
unittests	78.18% <90.00%> (+0.17%)	⬆️
unittests_timing	13.93% <0.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
iceoryx_posh/source/roudi/process_manager.cpp	64.64% <75.00%> (ø)
...ceoryx_posh/source/roudi/roudi_cmd_line_parser.cpp	100.00% <100.00%> (ø)
...roudi/roudi_cmd_line_parser_config_file_option.cpp	94.73% <100.00%> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp	85.71% <0.00%> (-5.72%)	⬇️
iceoryx_posh/source/roudi/port_manager.cpp	84.48% <0.00%> (-0.39%)	⬇️
...osh/include/iceoryx_posh/internal/popo/request.inl	100.00% <0.00%> (ø)
...sh/include/iceoryx_posh/internal/popo/response.inl	100.00% <0.00%> (ø)
.../internal/relocatable_pointer/relative_pointer.inl	100.00% <0.00%> (ø)
...e/relocatable_pointer/base_relocatable_pointer.cpp
.../internal/relocatable_pointer/relative_pointer.hpp	100.00% <0.00%> (ø)
... and 1 more