Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang-Tidy integration #299

Closed
3 tasks done
elfenpiff opened this issue Sep 18, 2020 · 1 comment · Fixed by #1175
Closed
3 tasks done

Clang-Tidy integration #299

elfenpiff opened this issue Sep 18, 2020 · 1 comment · Fixed by #1175
Assignees
@dkroenke
Labels
enhancement New feature
Milestone
Low prio

Comments

@elfenpiff
Copy link
Contributor

elfenpiff commented Sep 18, 2020 •
edited
Loading

Brief feature description

We should use clang-tidy to verify our coding guidelines. There is already clang-tidy available in utils and posh but we have to enhance it and also use it in binding_c where we have a different code style or in utils/cxx.

  • Integrate clang-tidy into the IDE of the developers so that they are getting hints when the violating rules
  • use commit hooks for clang-tidy
  • Fix clang-tidy warnings in code base
@elfenpiff elfenpiff added the enhancement New feature label Sep 18, 2020
@elfenpiff elfenpiff mentioned this issue Sep 18, 2020
Merged
@mossmaurice mossmaurice added this to the v2.0 milestone Nov 4, 2020
@elBoberido elBoberido mentioned this issue Nov 24, 2020
Merged
19 tasks
@marthtz marthtz mentioned this issue Mar 16, 2021
Merged
19 tasks
@dkroenke dkroenke mentioned this issue May 26, 2021
Closed
4 tasks
@dkroenke dkroenke mentioned this issue Aug 13, 2021
Closed
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Re-enable PR check for Clang-Tidy
d0df660
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Re-enable PR check for Clang-Tidy
7c6b570
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Temp: Some change in header
3469e68
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Use another changed file script
0229e42
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Use another changed file script
b77e434
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Re-enable PR check for Clang-Tidy
6f58f3d
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Temp: Some change in header
7a3c4a8
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 10, 2022
@dkroenke
iox-eclipse-iceoryx#299 Temp: test other gh action for changed files
713ec3c
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 11, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fetch diff files on workflow
9caf43a
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Set gcc version in CI to 11
b62e295
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Temp: test git diff in script
1f5d5f9
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Temp: test git diff in script
3f8e4da
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Temp: test git diff in script
2575a88
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Temp: test git diff in script
05966e6
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Set version numbers for gcc in CI
c375e3c
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fix clang-tidy check in CI
96a44d9
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fix some clang-tidy warnings
eec447e
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fix clang-tidy check in CI
3fc5271
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fix some clang-tidy warnings
e312f1f
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Set version numbers for gcc in CI
033f9b4 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fix clang-tidy check in CI
d396a5c 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 14, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fix some clang-tidy warnings
74c60bd 
Signed-off-by: Dietrich Krönke <[email protected]>
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 15, 2022
@dkroenke
iox-eclipse-iceoryx#299 Remove c-binding from clang-tidy
3d78260
@dkroenke dkroenke mentioned this issue Feb 15, 2022
Merged
21 tasks
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Feb 15, 2022
@dkroenke
iox-eclipse-iceoryx#299 Fix git diff job
69217ca
dkroenke added a commit that referenced this issue Feb 16, 2022
@dkroenke
Merge pull request #1111 from ApexAI/iox-#299-enable-clang-tidy-PR-check
12d1906 
Iox #299 Clang-Tidy Pull-Request job
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2022
@elfenpiff
iox-eclipse-iceoryx#299 Remove multiple warnings from clang-tidy defa…
5f244b3 
…ult config

Signed-off-by: Christian Eltzschig <[email protected]>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Feb 28, 2022
@elfenpiff
iox-eclipse-iceoryx#299 Remove naming warnings
45e7f2b 
Signed-off-by: Christian Eltzschig <[email protected]>
@elfenpiff elfenpiff linked a pull request Feb 28, 2022 that will close this issue
Iox #299 fix clang tidy warnings #1175
Merged
21 tasks
@elfenpiff elfenpiff mentioned this issue Feb 28, 2022
Merged
21 tasks
elfenpiff added a commit that referenced this issue Feb 28, 2022
@elfenpiff
Merge pull request #1175 from ApexAI/iox-#299-fix-clang-tidy-warnings
2b9ab0d 
Iox #299 fix clang tidy warnings
@mossmaurice mossmaurice reopened this Feb 28, 2022
@elfenpiff
Copy link
Contributor Author

The clang-tidy integration is finished, now we have to enable all checks and get rid of the warnings. This is done in the issue #1196

This issue is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkroenke dkroenke

Labels
enhancement New feature
Projects
None yet
Milestone
Low prio
Development

Successfully merging a pull request may close this issue.

Iox #299 fix clang tidy warnings ApexAI/iceoryx
3 participants
@mossmaurice @dkroenke @elfenpiff