Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize configuration in the server #123

Closed
tortmayr opened this issue Sep 18, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#95
Closed

Centralize configuration in the server #123

tortmayr opened this issue Sep 18, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#95
Assignees
@tortmayr @CamilleLetavernier
Labels
improvement

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Sep 18, 2020 •
edited by planger
Loading

Currently the configuration is spread across client and server for a few aspects, as follows:

Currently the client tells the server (via RequestModelAction options) whether clientLayout is needed to for this diagram or not.
IMO this is a flaw in the general design because a) The client should not have this knowledge in the first place and it should be provided by the server and b) The need for clientLayouting doesn't change on a per-model base. So this configuration can already be done during the server initialization.

If there is a handler registered in the server, the server should automatically be registered as a handler on the client. The server could notify the client about the actions it wants to handle with a message during the initialization phase. (originally #121)

Remove ServerConfiguation and integrate into DiagramConfiguration (originally #118)

Potentially related to #122
@planger planger changed the title Rework clientLayout configuration Centralize configuration in the server Sep 18, 2020
This was referenced Sep 18, 2020
Closed
Closed
CamilleLetavernier added a commit to CamilleLetavernier/glsp-client that referenced this issue Sep 24, 2020
@CamilleLetavernier
eclipse-glsp#123 Centralize configuration in the server
7387a78 
- Add ConfigureServerHandlersAction

refs eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
CamilleLetavernier added a commit to CamilleLetavernier/glsp-server that referenced this issue Sep 24, 2020
@CamilleLetavernier
eclipse-glsp#123 Centralize configuration in the server
f62d7e5 
refs eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
planger added a commit to eclipse-glsp/glsp-client that referenced this issue Sep 30, 2020
@CamilleLetavernier @planger
#123 Centralize configuration in the server (#87)
5c0863f 
* #123 Centralize configuration in the server

- Add ConfigureServerHandlersAction

refs eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
Signed-off-by: Philip Langer <[email protected]>
Co-authored-by: Philip Langer <[email protected]>
planger added a commit to eclipse-glsp/glsp-server that referenced this issue Sep 30, 2020
@CamilleLetavernier @planger
#123 Centralize configuration in the server (#80)
d1585c8 
* #123 Centralize configuration in the server

refs eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
Signed-off-by: Philip Langer <[email protected]>
Co-authored-by: Philip Langer <[email protected]>
CamilleLetavernier added a commit to CamilleLetavernier/glsp-server that referenced this issue Nov 24, 2020
@CamilleLetavernier
eclipse-glsp#122 eclipse-glsp#123 Centralize configuration in the server
33877f1 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
@CamilleLetavernier CamilleLetavernier mentioned this issue Nov 24, 2020
Closed
planger pushed a commit to eclipse-glsp/glsp-server that referenced this issue Dec 16, 2020
@CamilleLetavernier @planger
#122 #123 Centralize configuration in the server
85d8a22 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
planger pushed a commit to eclipse-glsp/glsp-server that referenced this issue Dec 16, 2020
@CamilleLetavernier @planger
#122 #123 Centralize configuration in the server
3d89791 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
@planger planger mentioned this issue Dec 16, 2020
Merged
tortmayr pushed a commit to eclipse-glsp/glsp-server that referenced this issue Dec 16, 2020
@planger @CamilleLetavernier
#122 #123 Centralize configuration in the server (#95)
2e3da5b 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>

Co-authored-by: Camille Letavernier <[email protected]>
@planger planger mentioned this issue Dec 21, 2020
Closed
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Dec 21, 2020
@planger
Removes needsClientLayout flag
c868830 
eclipse-glsp/glsp#123
@planger planger mentioned this issue Dec 21, 2020
Merged
planger added a commit to eclipse-glsp/glsp-client that referenced this issue Dec 21, 2020
@planger
Removes needsClientLayout flag
ee4fb3f 
eclipse-glsp/glsp#123
@planger planger mentioned this issue Dec 21, 2020
Merged
tortmayr pushed a commit to eclipse-glsp/glsp-client that referenced this issue Dec 21, 2020
@planger
Removes needsClientLayout flag (#98)
1e5b4a8 
eclipse-glsp/glsp#123
tortmayr pushed a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Dec 21, 2020
@planger
Removes needsClientLayout flag (#60)
1a6720e 
eclipse-glsp/glsp#123
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@CamilleLetavernier @planger @holkerveen
eclipse-glsp#123 Centralize configuration in the server (eclipse-glsp#87
1b2c44e 
)

* eclipse-glsp#123 Centralize configuration in the server

- Add ConfigureServerHandlersAction

refs eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
Signed-off-by: Philip Langer <[email protected]>
Co-authored-by: Philip Langer <[email protected]>
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@planger @holkerveen
Removes needsClientLayout flag (eclipse-glsp#98)
fe61186 
eclipse-glsp/glsp#123
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@CamilleLetavernier @planger @holkerveen
eclipse-glsp#123 Centralize configuration in the server (eclipse-glsp#87
574c457 
)

* eclipse-glsp#123 Centralize configuration in the server

- Add ConfigureServerHandlersAction

refs eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
Signed-off-by: Philip Langer <[email protected]>
Co-authored-by: Philip Langer <[email protected]>
holkerveen pushed a commit to holkerveen/glsp-client that referenced this issue Dec 21, 2024
@planger @holkerveen
Removes needsClientLayout flag (eclipse-glsp#98)
da5a9a9 
eclipse-glsp/glsp#123
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@CamilleLetavernier @planger
eclipse-glsp#123 Centralize configuration in the server (eclipse-glsp#80
ee0273d 
)

* eclipse-glsp#123 Centralize configuration in the server

refs eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
Signed-off-by: Philip Langer <[email protected]>
Co-authored-by: Philip Langer <[email protected]>
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@planger @CamilleLetavernier
eclipse-glsp#122 eclipse-glsp#123 Centralize configuration in the ser…
17b959b 
…ver (eclipse-glsp#95)

- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>

Co-authored-by: Camille Letavernier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

@CamilleLetavernier CamilleLetavernier

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#122 #123 Centralize configuration in the server eclipse-glsp/glsp-server
2 participants
@tortmayr @CamilleLetavernier