Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize model update protocol in Model Submission Handler #122

Closed
tortmayr opened this issue Sep 18, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#95
Closed

Centralize model update protocol in Model Submission Handler #122

tortmayr opened this issue Sep 18, 2020 · 0 comments · Fixed by eclipse-glsp/glsp-server#95
Assignees
@CamilleLetavernier
Labels
improvement server-java

Comments

@tortmayr
Copy link
Contributor

OperationActionHandler (and other handlers) should only inject the model submission handler and call a submit method. They should not know wehter the want to send a RequestBoundsAction or an UpdateModelAction (or maybe something entirely different).
@tortmayr tortmayr mentioned this issue Sep 18, 2020
Closed
CamilleLetavernier added a commit to CamilleLetavernier/glsp-server that referenced this issue Nov 24, 2020
@CamilleLetavernier
eclipse-glsp#122 eclipse-glsp#123 Centralize configuration in the server
33877f1 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
@CamilleLetavernier CamilleLetavernier mentioned this issue Nov 24, 2020
Closed
planger pushed a commit to eclipse-glsp/glsp-server that referenced this issue Dec 16, 2020
@CamilleLetavernier @planger
#122 #123 Centralize configuration in the server
85d8a22 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
planger pushed a commit to eclipse-glsp/glsp-server that referenced this issue Dec 16, 2020
@CamilleLetavernier @planger
#122 #123 Centralize configuration in the server
3d89791 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>
@planger planger mentioned this issue Dec 16, 2020
Merged
tortmayr pushed a commit to eclipse-glsp/glsp-server that referenced this issue Dec 16, 2020
@planger @CamilleLetavernier
#122 #123 Centralize configuration in the server (#95)
2e3da5b 
- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>

Co-authored-by: Camille Letavernier <[email protected]>
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this issue Dec 21, 2024
@planger @CamilleLetavernier
eclipse-glsp#122 eclipse-glsp#123 Centralize configuration in the ser…
17b959b 
…ver (eclipse-glsp#95)

- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <[email protected]>

Co-authored-by: Camille Letavernier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CamilleLetavernier CamilleLetavernier

Labels
improvement server-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#122 #123 Centralize configuration in the server eclipse-glsp/glsp-server
2 participants
@tortmayr @CamilleLetavernier