Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#156 Use package-import rather than require-bundle for javax.servlet #94

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

CamilleLetavernier
Copy link
Member

  • Multiple bundles may provide javax.servlet packages, which can result in some conflicts at runtime. Using a strict package-import, with the same dependency range as Jetty, seems more reliable.

- Multiple bundles may provide javax.servlet packages, which can result
in some conflicts at runtime. Using a strict package-import, with the
same dependency range as Jetty, seems more reliable.

refs #eclipse-glsp/glsp/issues/156
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@tortmayr tortmayr merged commit 144ff21 into master Dec 7, 2020
@tortmayr tortmayr deleted the issues/156 branch December 7, 2020 11:14
dseebacher pushed a commit to dseebacher/glsp-server that referenced this pull request Jan 1, 2021
…ommunication (eclipse-glsp#73)

* eclipse-glsp#96 eclipse-glsp#94 Cleanup and refactor client-server communication

- Refactor client-server communication into a base protocol and a jsonrpc specific implementation (eclipse-glsp#94)
- Cleanup protocol and implement (previously unused) shutdown method
- Add ClientSessionManager to track lifecycle of GLSP client connections (eclipse-glsp#96)
- Add listener-mechanism to react to lifecycle changes (used in 
DefaultModelStateProvider)
- Remove (now obsolete) GLSPClientProxyProvider
- Fix wrong version of guava in org.eclipse.glsp.graph pom.xml
- Add unique applicationId to InitializeParameters

Part of:
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96

* Fix minors

* Adapt copyright headers and fix checkstyle warnings

Co-authored-by: Philip Langer <[email protected]>
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
…ommunication (eclipse-glsp#73)

* eclipse-glsp#96 eclipse-glsp#94 Cleanup and refactor client-server communication

- Refactor client-server communication into a base protocol and a jsonrpc specific implementation (eclipse-glsp#94)
- Cleanup protocol and implement (previously unused) shutdown method
- Add ClientSessionManager to track lifecycle of GLSP client connections (eclipse-glsp#96)
- Add listener-mechanism to react to lifecycle changes (used in 
DefaultModelStateProvider)
- Remove (now obsolete) GLSPClientProxyProvider
- Fix wrong version of guava in org.eclipse.glsp.graph pom.xml
- Add unique applicationId to InitializeParameters

Part of:
- eclipse-glsp/glsp/issues/94
- eclipse-glsp/glsp/issues/96

* Fix minors

* Adapt copyright headers and fix checkstyle warnings

Co-authored-by: Philip Langer <[email protected]>
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
…vax.servlet (eclipse-glsp#94)

- Multiple bundles may provide javax.servlet packages, which can result
in some conflicts at runtime. Using a strict package-import, with the
same dependency range as Jetty, seems more reliable.

refs #eclipse-glsp/glsp/issues/156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants