Skip to content

Commit

Permalink
#156 Use package-import rather than require-bundle for javax.servlet
Browse files Browse the repository at this point in the history
- Multiple bundles may provide javax.servlet packages, which can result
in some conflicts at runtime. Using a strict package-import, with the
same dependency range as Jetty, seems more reliable.
  • Loading branch information
CamilleLetavernier committed Dec 7, 2020
1 parent 959d63f commit 5de2ca4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Bundle-Vendor: Eclipse GLSP
Automatic-Module-Name: com.eclipsesource.glps.server.websocket
Bundle-RequiredExecutionEnvironment: JavaSE-11
Require-Bundle: javax.websocket;bundle-version="1.0.0";visibility:=reexport,
javax.servlet;bundle-version="3.1.0";visibility:=reexport,
org.eclipse.jetty.server;bundle-version="9.4.14";visibility:=reexport,
org.eclipse.jetty.servlet;bundle-version="9.4.14";visibility:=reexport,
org.eclipse.jetty.util;bundle-version="9.4.14";visibility:=reexport,
Expand All @@ -21,3 +20,4 @@ Require-Bundle: javax.websocket;bundle-version="1.0.0";visibility:=reexport,
org.eclipse.lsp4j,
org.eclipse.lsp4j.jsonrpc
Export-Package: org.eclipse.glsp.server.websocket
Import-Package: javax.servlet;version="[3.1.0,4.0.0)"

0 comments on commit 5de2ca4

Please sign in to comment.