Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting quiet mode to off by default #19

Closed
wants to merge 1 commit into from
Closed

setting quiet mode to off by default #19

wants to merge 1 commit into from

Conversation

senivam
Copy link
Contributor

@senivam senivam commented Dec 7, 2020

Signed-off-by: Maxim Nesen [email protected]

@senivam
Copy link
Contributor Author

senivam commented Dec 7, 2020

this PR aims to remove hard-coded logic which switches quiet mode to FALSE even if it shall be TRUE due to build errors on remote CI/CD tools which cannot be reproduced locally.

In conjunction with PR #8 this can create fully parametrized management for the quiet mode.

@senivam
Copy link
Contributor Author

senivam commented Dec 7, 2020

or both (my and #8) PRs shall be closed in favor of #16 which both solves hard-coded logic issue and adds parameter for external management.

@senivam senivam closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@senivam